When adding my facebook status feed to my personal site just now I realised that a coding oversight restricts the automatic blocks created for aggregated feeds to a minimum of 2 posts.

Now, for something like showing your facebook status on a Drupal site, you probably only want to show one item - that being your latest status update, not the last 2 or 5 etc... So, you'll need to go to 'modules/aggregator' and edit your copy of the aggregator.module file.

Look around line 269 for the following code - I've added a '1' to the array - this allows the aggregator blocks to offer you a display of just the most recent feed item.

Note: I found this issue with Drupal 5.1 - it may have been corrected since then...

      $form['block'] = array('#type' => 'select', '#title' => t('Number of news items in block'), '#default_value' => $value, '#options' => drupal_map_assoc(array(1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20)));
      return $form;
CommentFileSizeAuthor
#17 189935-17.patch1.88 KBdcam
#1 one_aggregator_item.diff734 bytesdafeder
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dafeder’s picture

dafeder
he/him
Location Philadelphia, PA
CreditAttribution: dafeder commented
Version: 5.1 » 6.12
FileSize
one_aggregator_item.diff734 bytes

In 6.12 this has yet to be changed. There are several threads on this but no one has offered an answer as to why this is the way it is. Adding 1 to the array seems to have no side-effects, so why not do so? In 6.x look at line 312 of aggregator.module.

Nick Robillard’s picture

Nick Robillard CreditAttribution: Nick Robillard commented

Yes! This really really really needs to be fixed. I can't think of any reason why there was no 1 in the first place. Patching isn't an option for me as Drupal core is updated too often. I'm tempted to mark this issue as critical - but i won't. :)

ParisLiakos’s picture

ParisLiakos CreditAttribution: ParisLiakos commented
Version: 6.12 » 8.x-dev

closed as duplicate #1482292: Lowest number of news items selectable for display in block is 2. Why not 1?

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev
Spokje’s picture

Spokje
Primary language Dutch
CreditAttribution: Spokje at Chromatic commented
Project: Drupal core » Aggregator
Version: 9.3.x-dev » 1.x-dev
Component: aggregator.module » Code
Issue summary: View changes

The aggregator module has been removed from Core in 10.0.x-dev and now lives on as a contrib module.
Issues in the Core queue about the aggregator module, like this one, have been moved to the contrib module queue.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Version: 1.x-dev » 2.x-dev
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Issue tags: +Needs reroll, +Needs tests
dcam’s picture

dcam CreditAttribution: dcam as a volunteer commented
Status: Active » Needs review
Issue tags: -Needs reroll, -Needs tests
FileSize
189935-17.patch1.88 KB

I've been ignoring this simple issue because I want to do away with the block plugins in favor of a view. After that it won't be a problem anymore. But when I started working on the view today I realized that we'll need to leave the plugin in the module until version 3 is released for backward compatibility. That's because there may be instances of the blocks such as those in Layout Builder that can't be automatically replaced by an update function. So some sites may choose to continue using the plugin for a while. We may as well fix this for them.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Status: Needs review » Reviewed & tested by the community 
+++ b/tests/src/Functional/AggregatorRenderingTest.php
@@ -83,6 +83,17 @@ class AggregatorRenderingTest extends AggregatorTestBase {
+  /**
+   * Tests the elements of the AggregatorFeedBlock settings form.
+   */
+  function testBlockSettingsForm() {
+    $this->drupalGet('/admin/structure/block/add/aggregator_feed_block/olivero');
+
+    foreach (range(1, 20) as $value) {
+      $this->assertSession()->optionExists('edit-settings-block-count', $value);
+    }
+  }

I am of the opinion that we don't need to test this, its a trivial change and we're wasting cpu cycles/time on each PR testing it, but happy for it to stay if you feel otherwise

dcam’s picture

dcam CreditAttribution: dcam as a volunteer commented

I am of the opinion that we don't need to test this, its a trivial change and we're wasting cpu cycles/time on each PR testing it

I agree. I was just trying to be thorough. I'll remove it from the patch.

  • dcam committed ad6c1159 on 2.x 
    Issue #189935 by dcam, dafeder, larowlan: Aggregator module blocks - add...

  • dcam committed 4398b61c on 1.x 
    Issue #189935 by dcam, dafeder, larowlan: Aggregator module blocks - add...
dcam’s picture

dcam CreditAttribution: dcam as a volunteer commented
Status: Reviewed & tested by the community » Fixed

Thanks to everyone who worked on this!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.