Drupal 6 used hook_perm(). In D7 it was changed to hook_permission().

Attached patch fixes it.

Files: 
CommentFileSizeAuthor
twitter_post-hook_perm.patch530 bytesJohn Franklin

Comments

Version:6.x-5.0» 6.x-5.x-dev
Status:Needs review» Needs work

Good catch! Patch doesn't apply to 6.x-5.x-dev. Please clone the repo and make a patch directly from it.

git apply twitter_post-hook_perm.patch
error: sites/all/modules/twitter/twitter_post/twitter_post.module: No such file or directory

Are you serious?

I am not the maintainer of this module. I am simply reviewing patches. I know this is an EXTREMELY simple patch, but it doesn't apply correctly. I can easily fix this patch, but per Drupal rules, I cannot RTBC it.

This module has huge number of open issues, far more than the single unpaid regular maintainer (juampy) can review alone. So, please make this simpler/easier for the maintainer and supply patches that correctly apply.

TL;DR: Yes.

Thanks @eosrei ;D

Version:6.x-5.x-dev» 7.x-5.x-dev
Status:Needs work» Fixed

Fixed. Thanks.

Status:Fixed» Needs work

@juampy: instead of fixing 6.x-5.x, you broke 7.x-5.x.

It needs to be twitter_post_perm() in http://drupalcode.org/project/twitter.git/blob/refs/heads/6.x-5.x:/twitt... (6.x) and twitter_post_permission() in http://drupalcode.org/project/twitter.git/blob/refs/heads/7.x-5.x:/twitt... (7.x) - now it's all the way around.

Version:7.x-5.x-dev» 6.x-5.x-dev
Status:Needs work» Fixed

LOL! Reverted on 7.x-5.x and fixed on 6.x-5.x.

Thanks

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.