Branch tests for the 7.x-1.x branch of the Title module keep failing with the following error:

Failed to run tests: run-tests.sh reported no tests were found. See review log for details..

Tests pass locally with run-tests.sh. This happens also when testing patches, in fact it seems that after a commit some times the branch tests are green. No idea of what is going on :(

Files: 
CommentFileSizeAuthor
#2 title-1900282-2.patch290 bytesplach
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch title-1900282-2.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Comments

Issue summary:View changes

Updated issue summary.

Status:Active» Needs review

Double check your .info file in the test submodule ... you've got files[] = title_test.module instead of files[] = title.test.

Project:Drupal.org Testbots» Title
Version:» 7.x-1.x-dev
Component:unexplained test failure» Code
Category:support» bug
Priority:Normal» Major
StatusFileSize
new290 bytes
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch title-1900282-2.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Thanks, didn't notice that!

The files[] directive you are suggesting is already present in the parent module, I guess we can skip it altogether.

Committed and pushed the patch above, let's see if things are ok now.

Nope, still getting the error :(

Moreover I saw that the dependency tree has a couple of weird values:

                    [2] => Array
                        (
                            [repository] => Array
                                (
                                    [type] => git
                                    [url] => git://git.drupal.org/project/entity_translation.git
                                )
                            [vcs_identifier] => 7.x-1.0-beta1
                        )

The last stable release of ET is beta2 and has been for a couple of months now.

                    [3] => Array
                        (
                            [repository] => Array
                                (
                                    [type] => git
                                    [url] => git://git.drupal.org/project/lingotek.git
                                )
                            [vcs_identifier] => 7.x-1.61
                        )

This module is no required and does not appear anyhere in the .info files.

I'm wondering whether this could be the cuplrit:

dependencies[] = system (> 7.14)

Project:Title» Drupal.org Testbots
Version:7.x-1.x-dev»
Component:Code» unexplained test failure
Category:bug» support
Priority:Major» Normal
Status:Needs review» Active

I tried to rebuild the dependencies via jenkins, but still get the same results. Believe I need to get permissions to the script which removes the project_dependency source code cache, and will come back to this once I get that straightened out.

The system line might be messing with something, as I get an empty entry at the end of the dependencies array:

Array
(
    [1873988] => Array
        (
            [uri] => entity
            [version] => 7.x-1.0
            [tag] => 7.x-1.0
            [dependency_type] => 0
        )
    [1829790] => Array
        (
            [uri] => entity_translation
            [version] => 7.x-1.0-beta1
            [tag] => 7.x-1.0-beta1
            [dependency_type] => 0
        )
    [1861746] => Array
        (
            [uri] => lingotek
            [version] => 7.x-1.61
            [tag] => 7.x-1.61
            [dependency_type] => 0
        )
    [] => Array
        (
            [uri] =>
            [version] =>
            [tag] =>
            [dependency_type] => 0
        )
)

If clearing the sourcecode cache and rebuilding doesn't resolve this, I'll bump it to project_dependency as a bug.

Status:Active» Needs review

Same result after clearing the sourcecode cache and rebuilding the dependencies.

Can you try removing the space after the > symbol dependencies[] = system (> 7.14)? It looks like the examples at http://drupal.org/node/542202 don't have any spaces after the operators, and if the project_dependency code is assuming no space, that may be what's introducing the extra entries in the dependency array.

Bot green!

Status:Needs review» Fixed

Thanks a lot, Jeremy!

I'm sorry but I have to reopen this :(

The error is still there: a patch review failed reporting no tests were found: http://qa.drupal.org/pifr/test/438173.

By the way I looked to the review log of the dev branch which now is green and the dependency tree still has those wrong values, which I guess are not the culprit then.

Status:Fixed» Active

Same issue with a Chessboard patch here: http://qa.drupal.org/pifr/test/438708
This is my first test run since the PIFR update.

I realized that the mentioned patch itself probably killed bot class loading. I'll check later, but for now please disregard #13.

K ... I isolated this test on a bot to do some troubleshooting ... the bot has properly located the test file, and is passing the test request on to simpletest via the following command:

/usr/bin/php ./scripts/run-tests.sh --concurrency 8 --php /usr/bin/php --url 'http://drupaltestbot953/checkout' --file sites/default/modules/title/tests/title.test

It is simpletest which is firing back the error message saying that no tests were found. Can you try executing that test via the run_tests.sh script from drupal root, as follows:

/path/to/php ./scripts/run-tests.sh --url 'http://drupalsite' --file 'path/to/module/tests/title.test'

If you can make that work locally, it should also work on the bots.

As I reported in the OP running the tests from the command line works. I tried to dig in a bit more and this is what I found:

php .\scripts\run-tests.sh --php \xampp\php\php.exe --url http://test.d7.local --file sites\all\modules\title\tests\title.test

Tests are found and pass.

php .\scripts\run-tests.sh --php \xampp\php\php.exe --file sites\all\modules\title\tests\title.test --url http://test.d7.local

Tests are not found: ERROR: No valid tests were specified.

I'm wondering whether this may have anything to do with this issue.

I'm wondering whether this may be caused by the fact that the Entity module is required only by tests.

Status:Active» Postponed (maintainer needs more info)

This actually does *not* work from the command line, contrary to #16. I had the testbot build the whole thing and then ran it manually.

So it's either a problem with the code itself of a problem with drupal core and the run_tests.sh. I do notice using debugs that several of the classes in your .test file do not get loaded into $all_tests (although a couple of them do...)

For your convenience I've provided the full checkout on the testbot and the database provided by the testbot.

Files: https://www.dropbox.com/s/esm4m3m6fm5xeaf/title_test_full_files.tgz
Database: https://www.dropbox.com/s/mlzbb2nj8dqflyz/title_test.sql.gz

Thanks, I'll see if I can reproduce the errors locally, maybe it's a platform issue, since I'm on windows. If I can't I'll try on an ubuntu box.

Just for the record, now tests on the dev branch are green again (I just created a new tagged release).

Issue summary:View changes

Updated issue summary.