Wizard: More details in the error message [#1902652]

In the final step of the wizard, I got the following error message:

Unable to create sites/default/themes.                                                                                           [error]
Failed to generate subtheme.                                                                                                     [error]

This is because my chosen directory (1) didn't exist and (2) the /sites/default directory was not writable.

1. SUPER annoying because now I have to walk through the entire wizard again. Is there a way to deal with this in the wizard? I don't think you want to pick the location first (i.e. change the order of the wizard steps)...but I wonder if you want to put the risk-of-failure stuff closer to the beginning so that you're losing less work if it fails?

2. Should there be an output at the end of the error message which says something to the effect of, "Before running the wizard again, ensure you have created the destination folder for your new sub-theme and it is writable by the drush user." ?

(very, very low priority and should be an obvious fix if people run into the problem)

Comments

Comment #1

fubhy CreditAttribution: fubhy commented 30 January 2013 at 06:46

what we can do is this: Set up a while() loop at the end of the wizard where it moves the generated theme folder from the temporary folder to its final destination. If that operation fails, give a verbose error message so that it can be fixed, once the permissions are good, you can hit enter again and it tries it again... and again... and again... :)

Do you want to try again? (y/n)

Comment #2

emmajane CreditAttribution: emmajane commented 30 January 2013 at 15:15

Hm. In theory I'd need a new shell window open to be able to fix the error without leaving the wizard? I don't usually work with screen, or generally split my work on a server into multiple areas...so this wouldn't help me. I'm pretty inefficient though, so it might be perfect for "normal" people?

Comment #3

fubhy CreditAttribution: fubhy commented 30 January 2013 at 15:41

you can still break out of the check by simply going CTRL+C or [no] for cancel ([yes] = try again).

Comment #4

emmajane CreditAttribution: emmajane commented 30 January 2013 at 20:52

Just to confirm: Breaking out of the check would also force me to restart the wizard, right?

Comment #5

fubhy CreditAttribution: fubhy commented 31 January 2013 at 08:08

Yes... What we can do is this: Generate the "drush omega-subtheme" command according to your input for the "drush omega-wizard" command and simply do something like this:

"There seems to be a problem with the permissions on the destination folders. Please fix... blablabla... and then run this command:

drush omega-subtheme --machine-name=something .... (<--- direct command according to the previous input)