Comment delete and edit to open in overlay

Attachiog patch that includes comment edit and delete pages as admin pages.

Re-rolling patch with correct indentation.

Sorry

Hi plopesc,

Could you include screenshots before and after the patch apply, please?

It would be great to reviewers in order to find what has changed with your patch.

Also please, review the patch indentation, there is a wrong indentation in the return sentence ;)

Thanks :)

Attaching screenshots.

All them were taken after clicking on edit and delete links in comment page.

Firstly edit and delete comment pages without patch.

Now, same pages after patch applied. Both are opened in overlay:

Regards

Great, the patch works as shown in the screenshots.

Well done!

This makes sense to me.

Hmm it doesn't really make sense to me to be honest.

Users can post and edit comments (and sometimes only do that) on lots of sites, and that's not administrative when they're editing their own comments. In this case the overlay would be shown only for this particular action and never for anything else.

We have a setting for the node form for each node type, why not the same for comments? Or have a global setting for comments but inherit the node type settings based on the comment bundle?

The overlay is disabled on small screen sizes at the moment too, so most mobile users won't see it.

Hi catch,

Have applied the patch and it seems to work the way you want.

Since we can set the permission for different roles to see the overlay, authenticated user will not be able to see the overlay unless we change the permission. Please check the screenshot.

Been talking to JohnAlbin, we think adding option to global setting and node settings will make user confused. i.e. what if we have permission disabled but the option for displaying overlay ticked in node? Or we have to set default value according to the permission?

Happy to discuss with you.

rli

Yhea, I dont think this is a really good idea - comments is not really a site building task. For many cases, it will be a user who only sees the front-end

I think only people with admin overlay permission will access to the comment edit overlay feature. As occurs with nodes.

Managing comments could be another site building task, site admins can manage and moderate comments if desired.

Regards

agree. This patch does make sense to me.

Still needs more discussion and possibly testing.

While I have some administrative permissions on Drupal.org, I only ever edit my own comments to fix typos etc. and having those appear in the overlay would irritate me no end.

Would that then be a case for users being able to (should they have requisite permissions) disable overlay.

If I am reading your comments in #7 and #13 correctly catch:

• Use overlay for comment edit/delete
• Add in option on content types page to set node defaults for comment edit/delete.
• Add in option on node creation to allow override of defaults.

In addition to this, if this is to go ahead, I propose:

• Add setting on user edit page to allow users with above permission to alter settings (much in the same way that users are able to change settings for how they receive mail in contrib (subscriptions module I think) HTML / plaintext. See example below (obviously settings would be extended to include perhaps node edit and other things)

These additional options at least allow users who are not partial to using overlay in comments to opt out.

Yes, I agree with giving user options to disable overlay, as we already have this option in user/*/edit page.

But if we want to separate the settings for node and comment, I think we also need to do this to all of the modules that have admin page. In this case I suppose there would be a list of overlay settings in the page, which may make user confused?

Once we introduce settings per-user then should be sensible global defaults
Otoh for none-mobile visitors I'd prefer to use modal dialog to edit comments and there's issue for confirmations #1842036: [META] Convert all confirm forms to use modal dialog

Now we have no overlay in core, so probably issue could be closed #2088121: Remove Overlay

Or we could use ajax modal dialog.

sure, for delete it makes sense but comment-edit seems better to have a separate page

Yeah. Overlay is gone, the confirm delete can go in #1842036: [META] Convert all confirm forms to use modal dialog