Notice: Undefined index: #field_name in file_managed_file_save_upload()

This line should not give any errors anyways (modules/file/file.module:637)

    watchdog('file', 'The upload directory %directory for the file field !name could not be created or is not accessible. A newly uploaded file could not be saved in this directory as a consequence, and the upload was canceled.', array('%directory' => $destination, '!name' => $element['#field_name']));

I've seen the same issue when playing with Open Atrium 2 and uploading a banner image via the Media module.

Notice: Undefined index: #field_name in file_managed_file_save_upload() (line 637 of /webroot/atrium2.drupal.dev/modules/file/file.module).
The file could not be uploaded.

Changed the $element index to match the other one used in the same function later on.

I goto upload a file via the media module
I get the error above and can't upload the file
Notice: Undefined index: #field_name in file_managed_file_save_upload()
The file could not be uploaded.
Upload a new file field is required.

With the patch the error goes away, but I still can't upload the file with:
The file could not be uploaded.
Upload a new file field is required.

This patch wouldn't affect the ability to upload a file, so the error in #6 is unrelated. #6 actually confirms what this is fixing is fixed.

I still need to check drupal 8 for the same issue.

Did anyone check? Looks like extremely similar code exists in Drupal 8, so I would expect the bug is very likely to exist there too.

Not reroll. Just needs to be verified if this is fixed in D8 or not.

Same fix for Drupal 8, but changing "for the file field !name" to "for the !name field" since we cannot assume this is being used with a file field.

The same patch for Drupal 7 (marked as DNT).

This is a blocker for File Entity. We keep getting bug reports about this, anyone able to review the latest versions?

The patch in #18 works for me on D7. There is no notice any more.

the patch from #18 for D7 works for me too and allows the patch from #2074625: Allow filename (and possibly other attributes) to be edited during upload process on file_entity to work.

Tested the patch in #18 and it works, no longer getting the error message

Fixed paths in patch file from #18.

Same notices detected writing tests in Drupal 8.

You can see the notice using a managed_file in a theme settings: https://www.drupal.org/node/1862892#comment-11766744

And then the notices go way when apply the patch in #17: https://www.drupal.org/node/1862892#comment-11766843

For me patch in #17 is RTBC

Tested the patch in #18 and it works, no error message found.

Re-uploading #17 for testing since it's 18 months old. Didn't review yet.

Patch didn't make it.

Rerolled the patch in #17 to apply against the latest 8.2.x

Thanks for the re-roll.

The lack of test changes means we don't have test coverage for this hunk in file_managed_save_upload(), so let's add some here.

And this should pas.

@oriol_e9g #36 looking nice.
Please see notice-fix-and-test-1903010-38.png .

That's much better, thanks!

+++ b/core/modules/file/src/Tests/FileManagedFileElementTest.php
@@ -148,6 +148,13 @@ function testManagedFile() {
+    // Submit file to a folder without permissions to force message fail

Missing period on the end of the comment but that can be fixed on commit. Moving back to RTBC.

+++ b/core/modules/file/file.module
@@ -1183,7 +1183,7 @@ function file_managed_file_save_upload($element, FormStateInterface $form_state)
-    \Drupal::logger('file')->notice('The upload directory %directory for the file field %name could not be created or is not accessible. A newly uploaded file could not be saved in this directory as a consequence, and the upload was canceled.', array('%directory' => $destination, '%name' => $element['#field_name']));
+    \Drupal::logger('file')->notice('The upload directory %directory for the !name field could not be created or is not accessible. A newly uploaded file could not be saved in this directory as a consequence, and the upload was canceled.', array('%directory' => $destination, '!name' => $element['#title']));

We no longer support !placeholder so we should not use it with the logger either.

https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Component%21Rend...
https://www.drupal.org/node/2575819
https://www.drupal.org/node/2605274

Thanks!

Also the fact that the patch passed implies to me the test coverage isn't quite complete?

If you want, we can test that the notice is generated and saved correctly in the DBLog... but I don't know if it's really necessary for a notice message.

Random test fail, attached more compact test.

We can use this patch #46 or #43 if we think that it's not necessari test the notice message.

Small change to become more coherent!

Same problem in 8.3.7, but the patch doesn't apply cleanly for 8.3.x.

Needs a reroll (presumably since arrays are now in bracket syntax). Could somebody also re-upload the test-only patch since that has changed since the last test-only patch?

Re-rolled.

This seems to be in Drupal 8.6.x except for the array syntax change and the new test?

I am having same issue with Drupal 8.6.10 and the #56 patch is failing, I am new to Drupal and not using git
error i receive
Hunk #1 FAILED at 2.
Hunk #2 FAILED at 10.
patch unexpectedly ends in middle of line
Hunk #3 FAILED at 148.

any suggestions plz

Re-rolling for the current dev branch

Resolving deprecation notices

Fixed the CS issues in the patch #65

core/modules/file/file.module
1414 | ERROR   | [ ] The array declaration extends to column 301 (the limit is 80). The array content should be split up over
      |         |     multiple lines

core/modules/file/tests/src/Functional/FileManagedFileElementTest.php
 161 | ERROR   | [ ] The array declaration extends to column 101 (the limit is 80). The array content should be split up over multiple
     |         |     lines
 164 | ERROR   | [ ] The array declaration extends to column 298 (the limit is 80). The array content should be split up over multiple
     |         |     lines

Wow, 7 years since I wrote the first patch for this in D7 and the issue still isn't closed!

Thanks for the updated patch. We are using patch #68 and it fixed the fatal file_managed_file_save_upload error for a site with Drupal 9.2.11.

The patch applies with offsets to 9.3, 9.4, and 10.

[drupal-9.3.x-dev/9.3.x] [drupal-9.3.x-dev]$ patch -p1 < 1903010-68.patch 
patching file core/modules/file/file.module
Hunk #1 succeeded at 1433 with fuzz 2 (offset 22 lines).
patching file core/modules/file/tests/src/Functional/FileManagedFileElementTest.php
Hunk #3 succeeded at 151 (offset 4 lines).

[drupal-9.4.x-dev/9.4.x] [drupal-9.4.x-dev]$ patch -p1 < 1903010-68.patch 
patching file core/modules/file/file.module
Hunk #1 succeeded at 1435 with fuzz 2 (offset 24 lines).
patching file core/modules/file/tests/src/Functional/FileManagedFileElementTest.php
Hunk #3 succeeded at 151 (offset 4 lines).

[drupal-10.0.x-dev/10.0.x] [drupal-10.0.x-dev]$ patch -p1 < 1903010-68.patch 
patching file core/modules/file/file.module
Hunk #1 succeeded at 981 with fuzz 2 (offset -430 lines).
patching file core/modules/file/tests/src/Functional/FileManagedFileElementTest.php
Hunk #3 succeeded at 151 (offset 4 lines).

It would be good to have specific steps to reproduce so we can test on 9.4 and then get this issue committed :)

Looked at the code and one minor nitpick.

+++ b/core/modules/file/file.module
@@ -1411,7 +1411,10 @@ function file_managed_file_save_upload($element, FormStateInterface $form_state)
+    \Drupal::logger('file')->notice('The upload directory %directory for the @name field could not be created or is not accessible. A newly uploaded file could not be saved in this directory as a consequence, and the upload was canceled.', [

IMO this could be simplified so it's easier to read, e.g.

The upload directory %directory for the @name field could not be created or is not accessible, so the uploaded file was not saved.

Might also be nice to include the filename, e.g.

The upload directory %directory for the @name field could not be created or is not accessible, so the uploaded file %filename was not saved.

Addressed #73 & rerolled the patch against 9.4.x branch.

Updated patch will fix test failures. One thing missed in previous patch.