Problem/Motivation

Follow up from #916388-161: Convert menu links into entities

Some code in MenuTreeTest.php does not meet Drupal coding standards, in particular, arrays that should be written multi-line.

Proposed resolution

Fix the code according to the standards.

Remaining tasks

Prepare a patch.

User interface changes

None.

API changes

None.

Contributor tasks needed
Task Novice task? Contributor instructions Complete?
Create a patch Instructions
Manually test the patch Novice Instructions
Review patch to ensure that it fixes the issue, stays within scope, is properly documented, and follows coding standards Instructions
CommentFileSizeAuthor
#6 1903768-6.patch37.28 KBcilefen
#1 1903768-TreeOutput-formatting-1.patch7.34 KBchrisjlee
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

chrisjlee’s picture

chrisjlee CreditAttribution: chrisjlee commented
Status: Active » Needs review
FileSize
1903768-TreeOutput-formatting-1.patch7.34 KB

How's this?

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

I should have mentioned it, but we should better wait until #916388: Convert menu links into entities gets in, as both patches conflict with each other.

amateescu’s picture

amateescu CreditAttribution: amateescu commented
Status: Needs review » Postponed
amateescu’s picture

amateescu CreditAttribution: amateescu commented
Issue summary: View changes

Updated issue summary.

cilefen’s picture

cilefen CreditAttribution: cilefen commented
Title: Make TreeOutputTest::testMenuTreeData() easier to read » Fix coding standards in MenuTreeTest
Issue summary: View changes
Status: Postponed » Active
cilefen’s picture

cilefen CreditAttribution: cilefen commented
cilefen’s picture

cilefen CreditAttribution: cilefen commented
Status: Active » Needs review
FileSize
1903768-6.patch37.28 KB
smira’s picture

smira CreditAttribution: smira commented
Status: Needs review » Reviewed & tested by the community

cilefen's #6 patch applied cleanly and fixes all the indentation and array coding standards issues.
please commit,
Thank you!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Postponed

@dawehner how badly does this conflict with #2256521: [META] New plan, Phase 2: Implement menu links as plugins, including static admin links and views, and custom links with menu_link_content entity, all managed via menu_ui module? Lol that patch removes this test. Postponing this on that patch.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

@alexpott
The code is moved into multiple areas, so is the unit test, or actually it gets rewritten from scratch if I remember correctly.

cilefen’s picture

cilefen CreditAttribution: cilefen commented
Status: Postponed » Closed (won't fix)

This file is gone.