Follow-up to: #1838114: Change node form’s vertical tabs into details elements

Problem

  • Any HTML element that has a .status class is styled with an icon (intended for status messages).
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sun’s picture

Title: An independent .status CSS class should not trigger message/icon styles » Independent .status HTML class triggers message/icon styling
Status: Active » Needs review
Issue tags: +Needs themer review
FileSize
1.13 KB

Status: Needs review » Needs work

The last submitted patch, drupal8.css-messages.1.patch, failed testing.

jwilson3’s picture

Status: Needs work » Needs review

I completely agree with this change, and want to see more intelligent uses of adjoining css classes in core. CSSLint and IE6 be damned.

Not sure why this failed.. so give it another run...

sun’s picture

#1: drupal8.css-messages.1.patch queued for re-testing.

andymartha’s picture

Status: Needs review » Reviewed & tested by the community
FileSize
79.07 KB
73.23 KB

I can confirm that on a fresh installation of Drupal 8.x-dev from March 6th, 2013
1) creating a custom module to add a css class of status to a div or every div results in the checkmark icon being adding to the div

2) applying the patch drupal8.css-messages.1.patch in #1 by sun, then creating a custom module to add a css class of status to a div or every div results in a plain div while the status messages from Drupal core (eg drupal_set_message) still display the checkmark icon of status.
Please see screenshots. Not sure of the use case of this but, following the steps, it is unwanted behaviour fixed in my opinion.

Dries’s picture

Status: Reviewed & tested by the community » Fixed

Most arty bug ever. ;-)

Committed to 8.x. Thanks!

webchick’s picture

I think the award for Best Screenshot In The World Ever goes to andymartha! :D

Checkboxes, checkboxes everywhere

Automatically closed -- issue fixed for 2 weeks with no activity.