Problem/Motivation

The inline documentation is miss leading. see attached patch.

Files: 
CommentFileSizeAuthor
#8 1906484-8-field-ui-field-settings-form.patch539 bytesdcam
PASSED: [[SimpleTest]]: [MySQL] 40,295 pass(es).
[ View ]
field_ui_field_setting_form_submit_correction.patch577 bytessmiletrl
PASSED: [[SimpleTest]]: [MySQL] 49,129 pass(es).
[ View ]

Comments

Status:Active» Needs review

Status:Needs review» Needs work

The last submitted patch, field_ui_field_setting_form_submit_correction.patch, failed testing.

Status:Needs work» Needs review

Status:Needs review» Needs work

The last submitted patch, field_ui_field_setting_form_submit_correction.patch, failed testing.

Component:field system» documentation
Status:Needs work» Reviewed & tested by the community

Thanks for the patch! The test failures do not appear to be related to the patch. I'll wait to commit until we can get it to turn green though...

Version:8.x-dev» 7.x-dev
Status:Reviewed & tested by the community» Patch (to be ported)

Thanks again -- committed to 8.x.

I think we need to do the same patch in 7.x, but the patch here doesn't apply, so it needs to be ported.

Status:Patch (to be ported)» Needs review
StatusFileSize
new539 bytes
PASSED: [[SimpleTest]]: [MySQL] 40,295 pass(es).
[ View ]

Backported the patch in the OP to D7.

This patch is fine... thanks!

I also noticed when I went to api.drupal.org and looked up this function that it says
@ingroups forms
and it should be
@ingroup forms
[no s on @ingroup]

Could we go back to d8 and fix that, then fix both problems in d7, or should we start another issue? I just checked with grep and this is the only place in core that has this typo.

Status:Needs review» Fixed

I decided to commit the patch in #8 since I was doing some other 7.x commits anyway. Thanks!
Filed this follow-up issue for the @ingroups thing:
#1961832: Docs typo in field_ui.admin.inc

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.