Avatar Selection should integrate nicely with Avatar Approval which would be a nice complement, but they don't play nicely - Avatar Approval sends all Avatar Selection's pictures into approval queue.

Patch is coming.

CommentFileSizeAuthor
#2 avatar_selection-1906488-2.patch4.56 KBiva2k
#1 avatar_selection-1906488-1.patch4.53 KBiva2k
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

iva2k’s picture

iva2k CreditAttribution: iva2k commented
Status: Active » Needs review
FileSize
avatar_selection-1906488-1.patch4.53 KB

I've added implementation of hook_avatarapproval_competency_check() that let's Avatar Approval module know that it is Avatar Selection's picture to make complete integration with Avatar Approval. (see patch #7 in #1188120: Fixing many bugs in D7 port)

Also few one-liner fixes to issues #1883638: Avatar Selection unexpectedly shows on profile2 page #1883648: .info file should contain "configure = ..." #1883646: If user picture is not enabled upon install, the link in the message is wrong.

Also I changed
$form['#validate'][] = ... to array_unshift($form['#validate'], 'avatar_selection_validate_user_avatar');
as having data manipulation in validate hook should precede any other modules which may depend on this manipulation. For instance, I used avatar selection to quickly debug avatar approval module and this change was instrumental to make it all work.

Please review and commit.

iva2k’s picture

iva2k CreditAttribution: iva2k commented
FileSize
avatar_selection-1906488-2.patch4.56 KB

Change to the hook_avatarapproval_competency_check() API. Ignore patch #1.