Problem/Motivation

When clicking a contextual edit link, or any link that launches the overlay, the contextual menu remains present. It should be dismissed. This is occurring because the contextual menu is dismissed on mouseleave or blur -- apparently neither event is fired in this case.

Here's a screenshot of the issue:

Screenshot of a D8 site with the overlay open. The contextual menu that launched the overlay is visible to the right, above the darkened modal background that separates the overlay from the controlling page.

Proposed resolution

Find another event to trigger the links to close when a contextual link is clicked.

Remaining tasks

User interface changes

None.

API changes

None.

CommentFileSizeAuthor
#1 contextual-gears-bug-1910008-1.patch1.37 KBjessebeach
persistent-contextual-menu.png32.01 KBjessebeach
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jessebeach’s picture

jessebeach CreditAttribution: jessebeach commented
FileSize
contextual-gears-bug-1910008-1.patch1.37 KB

This patch adds a click handler that dimisses the highlighted region (thus dismissing the contextual links) when a contextual link is clicked or when enter is pressed on it.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Status: Active » Reviewed & tested by the community

Lovely :)

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented

Looks good to me too :)

yoroy’s picture

yoroy CreditAttribution: yoroy commented
Status: Reviewed & tested by the community » Needs review

I ran into this reviewing the edit in place stuff. Maybe we should verify the patch works by manually testing first before RTBC? :-)

yoroy’s picture

yoroy CreditAttribution: yoroy commented
Status: Needs review » Reviewed & tested by the community

Ah double post and a human review. Ok!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thanks!

I'll push when testbot has caught up a bit.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.