The audio, image, and video file types should default to a wildcard mimetype selector

Bumping to major. We shouldn't be requiring modules like media_youtube to be updating the file types themselves.

I'm a little confused as to the usage of fnmatch, since I've never seen that function before. It appears that according to http://php.net/manual/en/function.fnmatch.php it's not available on Windows PHP until 5.3.0, so let's use preg for regex instead of fnmatch.

Also if we're going to use a fnmatch() like pattern, then we should support all possible syntaxes that it can use, like *gr[ae]y!?

I would prefer we use something that checks for the characters *?[] in *any* part of the mimetype, and then do the following:

function file_entity_file_type($file) {
  $types = array();
  foreach (file_type_get_enabled_types() as $type) {
    if (in_array($file->filemime, $type->mimetypes)) {
      // The file mime type matches a file type exactly.
      $types[] = $type->type;
    }
    else {
      // Check to see if the file type contains wildcard mime types.
      $wildcards = array();
      foreach ($type->mimetypes as $mimetype) {
        if (strpbrk($mimetype, '*?[]')) {
          $wildcards[] = strtr(preg_quote($mimetype, '!'), array('\*' => '.*', '\?' => '.', '\[' => '[', '\]' => ']'));
        }
      }
      if (!empty($wildcards)) {
        $regex = '#' . implode('|', $wildcards) . '#';
        if (preg_match($regex, $file->filemime)) {
          $types[] = $type->type;
        }
      }
    }
    foreach ($type->mimetypes as $mimetype) {
      if (fnmatch($mimetype, $file->filemime)) {
        $types[] = $type->type;
      }
    }
  }
...

And we could add a @todo that this logic could be replaced by fnmatch() in Drupal 8.

My point with the code is #10 is that I love the fnmatch syntax as well, but we cannot rely on it. Which is why I emulated the use of fnmatch using preg_replace, but the actual syntax is the same. We could make a file_entity_fnmatch() wrapper that calls fnmatch directly if it exists, or does the alternative code if necessary.

We cannot rely on fnmatch because the minimum requirement for Drupal 7 is PHP 5.2, and this function isn't available at all on Windows systems until PHP 5.3.0. We also shouldn't define PHP-namespaced functions like that. If anything we should just use a wrapper named file_entity_fnmatch() that calls fnmatch() if it exists, or does the backup logic. Also note that fnmatch is case sensitive by default, so we cannot use the 'i' modifier in preg_match().

+++ b/file_entity.admin.incundefined
@@ -788,6 +788,20 @@ function file_entity_file_type_form_validate($form, &$form_state) {
+  $valid_wildcards = array();
+  foreach ($invalid_mimetypes as $mimetype) {
+    $parts = explode('/', $mimetype);
+    if ($parts[1] == '*') {
+      foreach ($valid_mimetypes as $valid) {
+        if (file_entity_fnmatch($mimetype, $valid)) {
+          $valid_wildcards[] = $mimetype;
+          break;
+        }
+      }
+    }
+  }
+  $invalid_mimetypes = array_diff($invalid_mimetypes, $valid_wildcards);
+

I feel like this logic and the one in file_entity_file_type() could use a helper function for 'does this mimetype match an array of possible mimetypes and mimetype wildcards'.

This should also be checking the other characters of ?[]. Also, the wildcard shouldn't be limited to only the second part of the mimetype. It should likely do a check like strpbrk($mimetype, '*?[]');

+++ b/file_entity.moduleundefined
@@ -1933,3 +1924,17 @@ function path_file_delete($file) {
+        return preg_match("#^".strtr(preg_quote($pattern, '#'), array('\*' => '.*', '\?' => '.'))."$#i", $string);

This needs to add support for '\[' => '[', '\]' => ']'

And it needs to remove the i modifier from the regex as fnmatch() is case-sensitive by default.

Follow-up for Media: Youtube - #1949520: Remove media_youtube_update_7202() and media_youtube_file_default_types_alter()

Notes posted in existing issues:
#1931136: Notify via hook_update_N / document that the file MIME types and displays may need to be rebuilt
#1850924: Create Mime types

Follow-up for Media: Vimeo - #1950188: Remove media_vimeo_update_7200() and media_vimeo_file_default_types_alter()