This is a sub-issue of #1910624: [META] Introduce and complete configuration schemas in all of core.

Problem/motivation

#1866610: Introduce Kwalify-inspired schema format for configuration introduced the idea of config schema. The changelog leads to (hopefully extensive) documentation on the format at http://drupal.org/node/1905070. While there are little cleanups planned for the format overall, the current format is a result of months of back and forths, so it should be perfectly fine to apply it more widely to core.

Proposed solution

Create a configuration schema for book module.

Schema in place

Schema not yet in place
book.settings.yml

CommentFileSizeAuthor
#11 no-config-changes.png130.76 KBYesCT
#11 change_config.png159.9 KBYesCT
#11 no_0.png158.34 KBYesCT
#9 1912302-book-schema-9.patch868 bytesvijaycs85
#8 1912302-book-schema-8.patch794 bytesvijaycs85
#8 2013-02-24_232253.png19.41 KBvijaycs85
#6 1912302-book-schema-6.patch557 bytesvijaycs85
#6 1912302-diff-4-6.txt842 bytesvijaycs85
#4 1912302-book-schema-4.patch601 bytesvijaycs85
#3 1912302-book-schema.patch607 bytesvijaycs85
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

gabriel.achille’s picture

gabriel.achille CreditAttribution: gabriel.achille commented
Assigned: Unassigned » gabriel.achille
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Issue tags: -sprint +Configuration schema

Tag for configuration schema.

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Status: Active » Needs review
FileSize
1912302-book-schema.patch607 bytes

Adding schema file...

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
FileSize
1912302-book-schema-4.patch601 bytes

updating key.

Status: Needs review » Needs work

The last submitted patch, 1912302-book-schema-4.patch, failed testing.

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Status: Needs work » Needs review
FileSize
1912302-diff-4-6.txt842 bytes
1912302-book-schema-6.patch557 bytes

Updating space issue with "mapping"...

gabriel.achille’s picture

gabriel.achille CreditAttribution: gabriel.achille commented
Assigned: gabriel.achille » Unassigned
vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Issue tags: -Configuration system, -D8MI, -language-config
FileSize
2013-02-24_232253.png19.41 KB
1912302-book-schema-8.patch794 bytes

Updated code style and verified with config_inspector
2013-02-24_232253.png

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
FileSize
1912302-book-schema-9.patch868 bytes

Ignore patch in #8. Updating correct patch file(screenshot in #8 applicable for this patch).

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Issue tags: +Configuration system, +D8MI, +language-config

Restore tags.

YesCT’s picture

YesCT CreditAttribution: YesCT commented
Status: Needs review » Reviewed & tested by the community
FileSize
no_0.png158.34 KB
change_config.png159.9 KB
no-config-changes.png130.76 KB

I looked at the (one) data yml file and the schema file side by side and visually inspected them. They looked to match.
http://drupal.org/node/1910624#steps-to-test
The schema file is in the schema directory (good). #1914366: Move all configuration schema files into a schema subdirectory

The inspector module, shows the form looking good. (example review instructions: #1910624-9: [META] Introduce and complete configuration schemas in all of core)
I also looked at the schema for code style, and it meets it (http://drupal.org/node/1905070#codestyle).

rtbc for that.

aside question:
why is there a 0 with the default config? I thought it might be the element in the array (sequence).
no-config-changes.png

but if I change the config and add more allowed types,
change_config.png

the 0 index goes away.
no_0.png

YesCT’s picture

YesCT CreditAttribution: YesCT commented

related to #11 #1928082: Make usage of book.settings:allowed_types consistent

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.