Create configuration schemas for breakpoint module

Tagging for config schema.

Adding patch

updating type from sequence to string.

#4: 1912308-breakpoint-schema-3.patch queued for re-testing.

Updating space issue with "mapping"...

for people coming in to test and review, see: http://drupal.org/node/1910624#steps-to-test in the issue summary for #1910624: [META] Introduce and complete configuration schemas in all of core
Those are draft instructions, please suggest improvements to them.

Updating code style fixes...

Those coding style changes look good.

Per http://drupal.org/node/1910624#steps-to-test,
still needs manual visual inspection of data .yml and schema .yml
and the inspector, see #1910624-9: [META] Introduce and complete configuration schemas in all of core

updating issue summary.

updating label with changed mapping type of multipliers

The coding style is good and the changes also seem to be reasonable.

I tested the patch with the configuration inspector.
Data is well covered. Looks good.

Add #SprintWeekend tag :).

Added Breakpoint and BreakpointGroup config entity definition to the breakpoint schema.

Needs review.

This did not actually seem to work with config inspector, so needs review/help.

The definition for breakpoint.settings could be tested using Configuration inspector. For the rest of the two definitions, I had a manual inspection. This covers all the data and seem perfect to me.

Thanks for the review rkjha. Could you give us a little more detail about why it needed manual inspection? What was it that causes Configuration inspector to fail?

The "patch" that failed testing was an interdiff that was badly named, so marking back to needs review. In the future, mr.york please upload interdiff with a .txt extension instead of .patch so test bot doesn't try to test them.

The breakpoint and breakpoint group config entities are defined with the breakpoint module. The module creates them based on breakpoints defined and places them in your active config store: sites/yorsite/files/config/active_....../. See the files there. Problem with config inspector is even though the schma existed, the config files did not show up in the inspector (although being in the active store, they should have).

Can someone help cross-check and help figure out why it did not work? Maybe it would work right away for you :D

@Gábor Hojtsy, I tested it and I found that the wildcard option working for just one part. so if we have breakpoint.breakpoint.module.toolbar.* I can see all configuration under it, but not breakpoint.breakpoint.module.*.*. Still checking where/who takes care of this...

That would be the schema mapper then in getDefinition() in core/lib/Drupal/Core/Config/Schema/SchemaDiscovery.php with the * resolving in getFallbackName() in the same class I think.

Thanks @Gábor Hojtsy. Created #1940440: Fix schema discovery to identify schema with more than one wildcard and submitted patch to fix this problem. I can see the patch fixing the problem locally with an error on multiplier(Please refer attached screenshot). We can fix this array issue and wait for #1940440: Fix schema discovery to identify schema with more than one wildcard.
After applying patch in #1940440-1: Fix schema discovery to identify schema with more than one wildcard:

Array to string conversion error:

#1940440: Fix schema discovery to identify schema with more than one wildcard is now fixed and committed, so this should work :) Can someone verify?

Updating schema error mentioned in #26 and attaching screenshot of inspector form. Found an issue similar to #1928082: Make usage of book.settings:allowed_types consistent for multipliers:

multipliers:
  1x: 1x

This can be fixed as separate issue.

Looks good to me, but we want to uppercase the module name too? :)

Sure, updating name...

Looks good to me.

Opened #1945228: Repetitive config in breakpoint.module for #28. Would be awesome if someone could write-up an issue summary over there.

Committed to 8.x, thanks! I'll push once testbot has caught up a bit.