Create configuration schemas for dblog module [#1912316]

This is a sub-issue of #1910624: [META] Introduce and complete configuration schemas in all of core.

Problem/motivation

#1866610: Introduce Kwalify-inspired schema format for configuration introduced the idea of config schema. The changelog leads to (hopefully extensive) documentation on the format at http://drupal.org/node/1905070. While there are little cleanups planned for the format overall, the current format is a result of months of back and forths, so it should be perfectly fine to apply it more widely to core.

Proposed solution

Create a configuration schema for dblog module.

Schema in place

Schema not yet in place
dblog.settings.yml

Comment	File	Size	Author
#15	dblog-after.png	528.49 KB	YesCT
#15	1912316-dblog-schema-15.patch	473 bytes	YesCT
#15
#15	interdiff-12-15.txt	410 bytes	YesCT
#13	dblog-compare.png	575.04 KB	YesCT
#12	dblog-schema-form.png	20.24 KB	sandipmkhairnar
#12	1912316-dblog-schema-12.patch	453 bytes	sandipmkhairnar
#12
#10	1912316-dblog-schema-10.patch	534 bytes	vijaycs85
#10
#10	1912316-diff-8-10.txt	426 bytes	vijaycs85
#8	1912316-dblog-schema-8.patch	540 bytes	vijaycs85
#8
#8	1912316-diff-6-8.txt	414 bytes	vijaycs85
#6	1912316-dblog-schema-5.patch	522 bytes	vijaycs85
#6
#6	1912316-diff-4-5.txt	542 bytes	vijaycs85
#4	1912316-dblog-schema-4.patch	360 bytes	vijaycs85
#4

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

torpy CreditAttribution: torpy commented 9 February 2013 at 04:22

Status:

Active

» Closed (duplicate)

This looks like it was fixed in #1493108: Convert logging and error settings to configuration system (commit #04a2523). Marking this as a duplicate.

Comment #2

gdd

he/him

English

Portland, OR

CreditAttribution: gdd commented 9 February 2013 at 04:28

Status:

Closed (duplicate)

» Active

That issue was about converting the settings to the config system, this issue is about creating the metadata schema for them. This schema was introduced in #1910624: [META] Introduce and complete configuration schemas in all of core and so none of the core settings have yet had schemas created (other than the ones converted as part of that patch.)

http://drupal.org/node/1905070 introduces the system and contains documentation on creating the schema files.

Comment #3

Gábor Hojtsy

he/him

Hungarian

Hungary

CreditAttribution: Gábor Hojtsy commented 14 February 2013 at 14:09

Issue tags:

-sprint

+Configuration schema

Add config schema tag instead of sprint.

Comment #4

vijaycs85

London, UK

CreditAttribution: vijaycs85 commented 16 February 2013 at 17:13

Status:

Active

» Needs review

File	Size
1912316-dblog-schema-4.patch	360 bytes

Adding schema file

Comment #5

16 February 2013 at 17:16

Status:

Needs review

» Needs work

The last submitted patch, 1912316-dblog-schema-4.patch, failed testing.

Comment #6

vijaycs85

London, UK

CreditAttribution: vijaycs85 commented 16 February 2013 at 17:17

Status:

Needs work

» Needs review

File	Size
1912316-diff-4-5.txt	542 bytes
1912316-dblog-schema-5.patch	522 bytes

updating wrong settings key

Comment #7

16 February 2013 at 17:19

Status:

Needs review

» Needs work

The last submitted patch, 1912316-dblog-schema-5.patch, failed testing.

Comment #8

vijaycs85

London, UK

CreditAttribution: vijaycs85 commented 16 February 2013 at 17:42

Status:

Needs work

» Needs review

File	Size
1912316-diff-6-8.txt	414 bytes
1912316-dblog-schema-8.patch	540 bytes

Updating mapping element.

Comment #9

16 February 2013 at 17:44

Status:

Needs review

» Needs work

The last submitted patch, 1912316-dblog-schema-8.patch, failed testing.

Comment #10

vijaycs85

London, UK

CreditAttribution: vijaycs85 commented 16 February 2013 at 21:01

File	Size
1912316-diff-8-10.txt	426 bytes
1912316-dblog-schema-10.patch	534 bytes

Updating space issue on "mapping"...

Comment #11

vijaycs85

London, UK

CreditAttribution: vijaycs85 commented 16 February 2013 at 21:02

Status:

Needs work

» Needs review

Comment #12

sandipmkhairnar CreditAttribution: sandipmkhairnar commented 26 February 2013 at 17:49

File	Size
1912316-dblog-schema-12.patch	453 bytes

dblog-schema-form.png	20.24 KB

updating schema as per code style in http://drupal.org/node/1905070#codestyle and verified in config_inspector
schema form

Comment #13

YesCT CreditAttribution: YesCT commented 28 February 2013 at 09:08

Status:

Needs review

» Needs work

File	Size
dblog-compare.png	575.04 KB

http://drupal.org/node/1905070#codestyle looks good for the schema.

but I think we can improve this to use the same label as is used in the ui. (patch coming)

also of note, small thing is in the data yml file, the integer does not have quotes, the config data in the sites files configHash dir does get quotes after saving the settings in the ui. (not a problem with this patch)

Comment #14

YesCT CreditAttribution: YesCT commented 28 February 2013 at 09:11

I wonder why the error messages to display are not in the schema or config data.

Comment #15

YesCT CreditAttribution: YesCT commented 28 February 2013 at 09:17

File	Size
interdiff-12-15.txt	410 bytes
1912316-dblog-schema-15.patch	473 bytes

dblog-after.png	528.49 KB

patch updates the label to match the label in the ui.

Comment #16

YesCT CreditAttribution: YesCT commented 28 February 2013 at 09:17

Status:

Needs work

» Needs review

Comment #17

vijaycs85

London, UK

CreditAttribution: vijaycs85 commented 28 February 2013 at 15:23

@YesCT:

also of note, small thing is in the data yml file, the integer does not have quotes, the config data in the sites files configHash dir does get quotes after saving the settings in the ui.

@alexpott mentioned that we have to have quotes for integer that are getting copied to active folder. So I guess, creating #1930226: Update integer/boolean values with quotes in configuration files. wouldn't hurt but to keep them consistent:)

I wonder why the error messages to display are not in the schema or config data.

This form is defined in system.module and using dblog_form_system_logging_settings_alter(), adding row_limit in this form. Other element (i.e. Logging level) is from system.logging.yml.

Comment #18

YesCT CreditAttribution: YesCT commented 28 February 2013 at 19:56

ok. that addresses my concerns I think. rtbc from me, but I made the most recent patch...
so if someone else could just give the patch a good look, I think we are good to go here.