This is a sub-issue of #1910624: [META] Introduce and complete configuration schemas in all of core.
Problem/motivation
#1866610: Introduce Kwalify-inspired schema format for configuration introduced the idea of config schema. The changelog leads to (hopefully extensive) documentation on the format at http://drupal.org/node/1905070. While there are little cleanups planned for the format overall, the current format is a result of months of back and forths, so it should be perfectly fine to apply it more widely to core.
Proposed solution
Create a configuration schema for dblog module.
Schema in place
Schema not yet in place
dblog.settings.yml
Comment | File | Size | Author |
---|---|---|---|
#15 | dblog-after.png | 528.49 KB | YesCT |
#15 | 1912316-dblog-schema-15.patch | 473 bytes | YesCT |
#15 | interdiff-12-15.txt | 410 bytes | YesCT |
#13 | dblog-compare.png | 575.04 KB | YesCT |
#12 | dblog-schema-form.png | 20.24 KB | sandipmkhairnar |
Comments
Comment #1
torpy CreditAttribution: torpy commentedThis looks like it was fixed in #1493108: Convert logging and error settings to configuration system (commit #04a2523). Marking this as a duplicate.
Comment #2
gddThat issue was about converting the settings to the config system, this issue is about creating the metadata schema for them. This schema was introduced in #1910624: [META] Introduce and complete configuration schemas in all of core and so none of the core settings have yet had schemas created (other than the ones converted as part of that patch.)
http://drupal.org/node/1905070 introduces the system and contains documentation on creating the schema files.
Comment #3
Gábor HojtsyAdd config schema tag instead of sprint.
Comment #4
vijaycs85Adding schema file
Comment #6
vijaycs85updating wrong settings key
Comment #8
vijaycs85Updating mapping element.
Comment #10
vijaycs85Updating space issue on "mapping"...
Comment #11
vijaycs85Comment #12
sandipmkhairnar CreditAttribution: sandipmkhairnar commentedupdating schema as per code style in http://drupal.org/node/1905070#codestyle and verified in config_inspector
Comment #13
YesCT CreditAttribution: YesCT commentedhttp://drupal.org/node/1905070#codestyle looks good for the schema.
but I think we can improve this to use the same label as is used in the ui. (patch coming)
also of note, small thing is in the data yml file, the integer does not have quotes, the config data in the sites files configHash dir does get quotes after saving the settings in the ui. (not a problem with this patch)
Comment #14
YesCT CreditAttribution: YesCT commentedI wonder why the error messages to display are not in the schema or config data.
Comment #15
YesCT CreditAttribution: YesCT commentedpatch updates the label to match the label in the ui.
Comment #16
YesCT CreditAttribution: YesCT commentedComment #17
vijaycs85@YesCT:
@alexpott mentioned that we have to have quotes for integer that are getting copied to active folder. So I guess, creating #1930226: Update integer/boolean values with quotes in configuration files. wouldn't hurt but to keep them consistent:)
This form is defined in system.module and using dblog_form_system_logging_settings_alter(), adding row_limit in this form. Other element (i.e. Logging level) is from system.logging.yml.
Comment #18
YesCT CreditAttribution: YesCT commentedok. that addresses my concerns I think. rtbc from me, but I made the most recent patch...
so if someone else could just give the patch a good look, I think we are good to go here.
Comment #19
Gábor HojtsyLooks good.
Comment #20
webchickCommitted and pushed to 8.x. Thanks!