All content types show "Group" tab

The issue is centered on the hooks defined in og_ui.api.php. When the hooks are used without checks for whether the content type is a group they add the group tab to every content type.

In og_massadd.module I commented out the function og_massadd_og_ui_get_group_admin_alter() which eliminates the group tab issue. But that also removes any link to the new functionality so I also added og_massadd_og_ui_get_group_admin so links are added to the group admin tab. I borrowed from og_ui_og_ui_get_group_admin where before adding the links it runs og_user_access which returns NULL if it's not a group and FALSE if the user doesn't have access.

function og_massadd_og_ui_get_group_admin($group_type, $gid) {
  $items = array();

  if (og_user_access($group_type, $gid, 'add user')) {
		$items['add_mass_people'] = array(
			'title' => t('Mass upload of user'),
			'description' => t('Mass add group members.'),
			'href' => 'admin/people/mass-add-user',
		);

		$items['find_add_mass_people'] = array(
			'title' => t('Find and add users'),
			'description' => t('Find and add group members.'),
			'href' => 'admin/people/mass-add-user-filter',
		);
  }
  return $items;
}

So that allows there to be links but doesn't add group tabs on every content type. Make sure to clear the cache if you update the module.

I haven't tried to figure out how to use og_massadd_og_ui_get_group_admin_alter() if that is needed. I'd welcome suggestions. Perhaps this code enough to make a patch.

I realised I had the same issue when the "Administer Group" tab appeared for all users, even the ones that did not have any admin rights. Though the tab was an empty page and therefore not a security threat. But still... The below code should fix the issue.
I am not setup to create a patch now, but hopefully the module maintainer can test/add this easy fix.

At line 95 of og_massadd.module, replace the og_massadd_og_ui_get_group_admin_alter function with this:

/* implements of hook_og_ui_get_group_admin_alter(). */
function og_massadd_og_ui_get_group_admin_alter(&$data, $gid) {
  // Hijack the add people to use a custom implementation.
  if(isset($data['add_people'])) {
    $data['add_people']['href'] = 'admin/people/mass-add-user-filter';
  }
}

Basically, this hijacks the add people link only when it exists.

Hoping hernani can take a look at this? Our D7 platform won't be using Organic Groups, but multisite instead.

Turned #3 into a patch.

Used #3 for removing group tab from all content type but that made Add people to go to default page not to the Group MassAdd page so added a condition mentioned in #4. All worked well.

Thanks for the help.

Patch applyes and works fine.

Commited to dev version.