Somehow I assumed this had been done along side #1179764: Convert Bartik to HTML5, but seems not.

It's not that complicated I don't think, but time's running out.

CommentFileSizeAuthor
#4 Seven-HTML5-1913692-4.patch3.04 KBmgifford
#1 Seven-HTML5-1913692-1.patch3.78 KBmgifford
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented
Status: Active » Needs review
Issue tags: +html5
FileSize
Seven-HTML5-1913692-1.patch3.78 KB

tagging and adding a simple patch.

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented

#1: Seven-HTML5-1913692-1.patch queued for re-testing.

echoz’s picture

echoz CreditAttribution: echoz commented

Would this come before or after #1938864: [meta] Update all core themes to use Twig?
If before, code looks good but why add the bartik piece in this patch?

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented
FileSize
Seven-HTML5-1913692-4.patch3.04 KB

I'm not sure about the order with regard to Twig. I do think since this patch is already written it would be fine to RTBC it (when it's just what it says it is).

The Twig folks may already be working on it (or not), but if we let them know they can decide how they want to approach it.

echoz’s picture

echoz CreditAttribution: echoz commented
Status: Needs review » Reviewed & tested by the community

Ok, keeping the bartik piece separate is what I needed, rtbc it is!

Dries’s picture

Dries CreditAttribution: Dries commented

Committed to 8.x. Thanks!

jessebeach’s picture

jessebeach CreditAttribution: jessebeach commented
Status: Reviewed & tested by the community » Postponed

So, the main element is still really new and it's not without controversy.

http://wiki.whatwg.org/wiki/Main_element

If we do end up keeping this version of page.tpl.php, we'll need to update the html5 shim in core.

I've opened a postponed critical issue, tagged to be revisited before release, with a patch for that. This new issue also has a built-in trigger to remove the main element from our templates if it isn't widely implemented enough by the time we need to ship D8. This will block the release of D8.

#1943120: Decide whether to keep the main tag in templates

jessebeach’s picture

jessebeach CreditAttribution: jessebeach commented
Status: Postponed » Reviewed & tested by the community

sorry, didn't mean to change the status. Setting it back to RTBC.

star-szr’s picture

star-szr
he/him
Primary language English
CreditAttribution: star-szr commented
Status: Reviewed & tested by the community » Fixed

Thanks @jessebeach! I think this can go to fixed since there was a commit in #6.

jessebeach’s picture

jessebeach CreditAttribution: jessebeach commented
Status: Fixed » Reviewed & tested by the community

mgifford, echoz, we need to get this followup committed: #1943142-1: Add the main element to the list of HTML5 elements that get set to display block

I just need a quick review from either of you (or anyone else). It's a one-line change.

jessebeach’s picture

jessebeach CreditAttribution: jessebeach commented
Status: Reviewed & tested by the community » Closed (fixed)

crosspost with Cottser. Setting back to fixed.