Here is a quick patch to handle geocoding from entity-properties. I removed also some remaining white spaces.

CommentFileSizeAuthor
#1 entity_property.patch4.83 KBPierco
entity_property.patch5.2 KBPierco
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Pierco’s picture

Pierco CreditAttribution: Pierco commented
FileSize
entity_property.patch4.83 KB

oops, sorry patch was wrong.

Simon Georges’s picture

Simon Georges CreditAttribution: Simon Georges commented
Status: Active » Needs review

Patch applies cleanly on current -dev, could somebody test the functionality?

SocialNicheGuru’s picture

SocialNicheGuru CreditAttribution: SocialNicheGuru commented

i am not sure what the patch does. can you elaborate?

rudiedirkx’s picture

rudiedirkx CreditAttribution: rudiedirkx commented
Issue summary: View changes

Ooh, this method uses existing object properties, not really using entity properties:

$field_original = array(array('value' => $entity->original->$field_name));

It won't work with multiple values.

I don't think this is a good method. It should use entity meta data wrappers, so the value is only created when it's necessary AND supports multiple values.

Like #2159925: Geocode from virtual fields/entity property instead of just real fields.

rudiedirkx’s picture

rudiedirkx CreditAttribution: rudiedirkx commented
Status: Needs review » Needs work
rudiedirkx’s picture

rudiedirkx CreditAttribution: rudiedirkx commented
Status: Needs work » Closed (duplicate)

Fixed by #2159925: Geocode from virtual fields/entity property instead of just real fields