The media plugin of ckeditor is not working in IE9 and below:

SCRIPT438: Object doesn't support property or method 'createRange'
plugin.js, line 31 character 17

I've also added a possible patch for this (don't know 100% sure if this is the correct solution), please review

CommentFileSizeAuthor
#5 ckeditor-media_ie_fix-1914904-5.patch863 bytesMiroslavBanov
#4 ckeditor-media_ie_fix-1914904-4.patch766 bytesrooby
ckeditor-media_plugin_ie9_and_below.patch555 bytesfilsterjisah
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rooby’s picture

rooby CreditAttribution: rooby commented
Status: Needs review » Reviewed & tested by the community

Works for me.

RTBC to get maintainer eyes on it.

rooby’s picture

rooby CreditAttribution: rooby commented
Status: Reviewed & tested by the community » Needs work

Actually, it doesn't seem to work with IE7.

You get:

SCRIPT438: Object doesn't support property or method 'toString'

rooby’s picture

rooby CreditAttribution: rooby commented

Now I'm getting that error in IE8 as well.

Weird because I'm sure it worked a couple of times.
Not sure if it is related to using IE9 in IE8 & IE7 modes.

rooby’s picture

rooby CreditAttribution: rooby commented
Status: Needs work » Needs review
FileSize
ckeditor-media_ie_fix-1914904-4.patch766 bytes

This works (tested in IE 7, 8, 9, 10, FF 20, Chrome 26, Safari 6) however I'm wondering why isn't already like this and I'm guessing it is because the getSelectedText() function was not in ckeditor until version 3.6.1, which means if we switch to this then users will have to upgrade to at least 3.6.1.

3.6.1 has been out for almost 2 years so I think it is ok to say ckeditor module 7.14 requires the ckeditor plugin 3.6.1 or higher.

People will get a better experience with a newer version and it means not having to code around older version quirks.

I'm interested to see what the maintainer's opinion of this is.

MiroslavBanov’s picture

MiroslavBanov CreditAttribution: MiroslavBanov commented
FileSize
ckeditor-media_ie_fix-1914904-5.patch863 bytes

I can confirm that patch #4 works with IE8 and IE9. I am also posting an alternative patch that should work for lower version of CKeditror.

  • Commit aa214db on 7.x-1.x authored by rooby, committed by wwalc: 
    Issue #1914904 by rooby: Media plugin not working in IE 9 and below.
wwalc’s picture

wwalc CreditAttribution: wwalc commented
Issue summary: View changes
Status: Needs review » Fixed

The code makes sense so I pushed it, though the plugin itself should be dropped as requested in #2140155: Remove media plugin, once this ticket is closed: #2159403: Make CKEditor plugin system modular and clean

rooby’s picture

rooby CreditAttribution: rooby commented

Thanks. I figured #2159403: Make CKEditor plugin system modular and clean would trump this one.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.