Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.The translatable tag was an attempt to make certain things that weren't translatable translatable by providing a schema and query flag/tag that would all contrib to alter things queries and e.g. join a table that contains the translation.
I think I've written the only implementation of that tag and while it kinda works, it is too limited to actually work. There is no way to control when the original should be displayed and when it should be translated into which language.
I think the two main approaches for translating things are now content/entity translation and config translation.
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | translatable-removed-1919022-12.patch | 7.37 KB | Berdir |
| #4 | translatable-removed-1919022-4.patch | 7.88 KB | Berdir |
| #1 | translatable-removed-1919022-1.patch | 3.5 KB | Berdir |
Comments
Comment #1
BerdirWhile a number of table columns still have the tag (I assume partially due to copy paste of definitions and forgetting to remove them), it looks like the only remaining cases where it is added to a query are node types and taxonomy terms.
Note 1: It is save to remove this flag from update functions as it never actually *did* something, it is just meta information for anyone who is parsing schema information, just like serialized.
Note 2: Those taxonomy term autocomplete queries should probably use the term storage controller to load the terms otherwise we won't be able to make them translatable properly.
Comment #2
plachThis looks good to me and I fully agree that the two main approaches for translating things are now content/entity translation and config translation. In note 2 are you referring to the two occurrences in
TermStorageControllerandtaxonomy.pages.inc?Comment #3
BerdirHm, I think I forgot the save a few files, the patch looks too small.
Comment #4
BerdirThis is more like it.
@plach: The one in taxonomy.pages.inc and (views...)/ajax.inc. Also, taxonomy_get_tree() is messy as well, but it at least optionally allows to load entities. We need lazy loading entites to clean that up. But neither are blocking this.
Comment #5
sunComment #6
plachLooks good, thanks. I agree we don't need update functions for this: nothing in core ever used this stuff, maybe a small change notice.
Comment #7
chx CreditAttribution: chx commentedchange notice written.
Comment #8
Dries CreditAttribution: Dries commentedAsking for a re-test.
Comment #9
Dries CreditAttribution: Dries commented#4: translatable-removed-1919022-4.patch queued for re-testing.
Comment #11
Gábor HojtsyI also support this change. (Got here via noticing the pre-written change notice :)
Comment #12
BerdirRe-roll after custom_block went in.
Comment #13
BerdirDidn't want to set it to RTBC.
Comment #14
Gábor HojtsyLooks good to me :)
Comment #15
webchickLess code, less confusion. Hooray!
Committed and pushed to 8.x. Thanks!
Looks like the change notice was already taken care of, so marking to fixed.