This is a sub-issue of #1910624: [META] Introduce and complete configuration schemas in all of core.
Problem/motivation
#1866610: Introduce Kwalify-inspired schema format for configuration introduced the idea of config schema. The changelog leads to (hopefully extensive) documentation on the format at http://drupal.org/node/1905070. While there are little cleanups planned for the format overall, the current format is a result of months of back and forths, so it should be perfectly fine to apply it more widely to core.
Proposed solution
Create a configuration schema for menu module.
Schema in place
Schema not yet in place
menu.menu.account.yml
menu.menu.admin.yml
menu.menu.footer.yml
menu.menu.main.yml
menu.menu.tools.yml
menu.settings.yml
Comment | File | Size | Author |
---|---|---|---|
#9 | 1919184-menu-schema-to-system-9.patch | 1.4 KB | vijaycs85 |
#5 | 1919184-menu-schema-5.patch | 860 bytes | nikhilasrani |
#5 | 1919184-diff-2-5.txt | 410 bytes | nikhilasrani |
#2 | 1919184-menu-schema-2.patch | 880 bytes | nikhilasrani |
#1 | 1919184-menu-schema-1.patch | 611 bytes | vijaycs85 |
Comments
Comment #1
vijaycs85Adding schema file...
Comment #2
nikhilasrani CreditAttribution: nikhilasrani commentedRe-rolling with below changes as advised in Schema code style:
1. moved from config to config/schema.
2. Updated labels.
Comment #3
vijaycs85Thank you for your patch. Just one thing.
Not sure about this label. Will have a word with @Gabor or @YesCT and RTBC it.
Comment #4
Gábor HojtsyI'm not really sure if I have a better suggestion for that label. "Menu" is good as well as it was used above, maybe more useful on the UI at the end.
Comment #5
nikhilasrani CreditAttribution: nikhilasrani commentedThanks @Gábor Hojtsy. Updated label as "Menu"
Comment #6
vijaycs85Thanks @nikhilasrani. RTBC, if comes back green.
Comment #7
webchickCommitted and pushed to 8.x. Thanks!
Comment #8
Gábor HojtsyThis seems wrong. In fact system module defines the Menu config entity, so menus can exist without menu module. Also menu module is not required, so to have schema coverage for those menus, I think the menu.menu.* should move to system schema.
Comment #9
vijaycs85Updating menu.menu.* to system.schema.yml.
Comment #10
Gábor HojtsyLooks good to me. Simply moves the relevant schema.
Comment #11
webchickHm. I guess that make sense. I'm a little leery of putting this into system's schema, but it's true that menu is a totally optional module for tweaking things, whereas the concept of a menu (currently) isn't.
Committed to 8.x, thanks! I'll push once testbot has caught up a bit.