This is a sub-issue of #1910624: [META] Introduce and complete configuration schemas in all of core.

Problem/motivation

#1866610: Introduce Kwalify-inspired schema format for configuration introduced the idea of config schema. The changelog leads to (hopefully extensive) documentation on the format at http://drupal.org/node/1905070. While there are little cleanups planned for the format overall, the current format is a result of months of back and forths, so it should be perfectly fine to apply it more widely to core.

Proposed solution

Create a configuration schema for node module.

Schema in place

Schema not yet in place
node.settings.yml

CommentFileSizeAuthor
#6 1919186-node-schema-6.patch458 bytesvijaycs85
#6 2013-02-24_222910.png12.85 KBvijaycs85
#1 1919186-node-schema-1.patch352 bytesvijaycs85
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Status: Active » Needs review
FileSize
1919186-node-schema-1.patch352 bytes

Adding schema file...

Status: Needs review » Needs work
Issue tags: -Configuration system, -D8MI, -language-config, -Configuration schema

The last submitted patch, 1919186-node-schema-1.patch, failed testing.

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Status: Needs work » Needs review
Issue tags: +Configuration system, +D8MI, +language-config, +Configuration schema

#1: 1919186-node-schema-1.patch queued for re-testing.

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented

FAILED: [[SimpleTest]]: [MySQL] Drupal installation failed.

locally installation seems fine - re-testing.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Needs review » Needs work 
+++ b/core/modules/node/config/node.schema.ymlundefined
@@ -0,0 +1,7 @@
+    "items_per_page":

no need for double quotes

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Status: Needs work » Needs review
FileSize
2013-02-24_222910.png12.85 KB
1919186-node-schema-6.patch458 bytes

Thanks for the review @alexpott. Updated:

1. Code style - as per http://drupal.org/node/1905070#codestyle
2. Added label
3. Verified with config_inspector (screenshot below)
2013-02-24_222910.png

pfrenssen’s picture

pfrenssen
Location Sofia
CreditAttribution: pfrenssen commented
Assigned: Unassigned » pfrenssen

Assigning for review.

pfrenssen’s picture

pfrenssen
Location Sofia
CreditAttribution: pfrenssen commented
Assigned: pfrenssen » Unassigned
Status: Needs review » Reviewed & tested by the community

Looks good!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.