While debugging https://drupal.org/node/1907960#comment-7084576, I found that verbose output on the testbot was displaying "An unrecoverable error has occured. You can find the error message below. It is advised to copy it to the clipboard for reference. Please continue to the error page", on the page after submitting the 'Apply all updates' POST. However, the test was not throwing any sort of failure on this page ... status was 200, HTML was valid, and the test moved happily along; only to fail on "No pending updates at the end of the update process" (since no updates were actually being processed all along ...)
Comment | File | Size | Author |
---|---|---|---|
#3 | UpgradePathTestBase.patch | 995 bytes | jthorson |
#2 | UpgradePathTestBase.patch | 994 bytes | jthorson |
Comments
Comment #1
jthorson CreditAttribution: jthorson commentedComment #2
jthorson CreditAttribution: jthorson commentedThis will trip an actual exception, though there may be a better way to catch things.
Comment #3
jthorson CreditAttribution: jthorson commentedOoops ... minor typo.
Comment #4
andypostThis should help to fight issues like #1907960-58: Helper issue for "Comment field"
Comment #5
andypostNot sure this helps. see #1907960-63: Helper issue for "Comment field"
Comment #6
webchickWell this has got to help something. :) Though it's strange that we have to manually check for all possible failure scenarios. Seems like there ought to be a way to clean that up some.
That double-negative was doing my head in a bit, but jthorson explained that if it were if ($this->assertText('…')) then the test would always fail. assertText() is the actual test run by Simpletest, and it handles the pass/fail on a per-assertion basis. So you need to assert the text does NOT exist, and the invert that check. Ouch!
Anyway. Committed and pushed to 8.x. Thanks!