I am creating a new node and getting the following message

Strict warning: Only variables should be passed by reference in sms_user_sms_send() (line 121 of /opt/bitnami/apps/drupal/htdocs/sites/all/modules/smsframework/modules/sms_user/sms_user.module).

CommentFileSizeAuthor
#7 smsframework-1923432-strict_error-7.patch693 bytestorpy
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

batje’s picture

batje CreditAttribution: batje commented

Am not sure if it fixes this problem, but this patch fixes a lot of issues around the sleep settings (which is what is called around that line) Please try applying it at report back.

phillipclarke29’s picture

phillipclarke29 CreditAttribution: phillipclarke29 commented

I applied the patch and got

Error
Error messagePDOException: SQLSTATE[42S22]: Column not found: 1054 Unknown column 'u.sleep_enabled' in 'field list': SELECT u.uid AS uid, u.number AS number, u.status AS status, u.code AS code, u.gateway AS gateway, u.sleep_enabled AS sleep_enabled, u.sleep_start_time AS sleep_start_time, u.sleep_end_time AS sleep_end_time FROM {sms_user} u WHERE (uid IN (:db_condition_placeholder_0)) ; Array ( [:db_condition_placeholder_0] => 1 ) in sms_user_user_load() (line 589 of /opt/bitnami/apps/drupal/htdocs/sites/all/modules/smsframework/modules/sms_user/sms_user.module).
The website encountered an unexpected error. Please try again later.

phillipclarke29’s picture

phillipclarke29 CreditAttribution: phillipclarke29 commented

ok - I unticked the "enable sleep hours" button on sms user options and the error has gone

batje’s picture

batje CreditAttribution: batje commented

Did you run updatedb after applying the patch? The update creates 3 new columns, one of them is missing in your error.

batje’s picture

batje CreditAttribution: batje commented
Status: Active » Fixed

The patch I referred to is now committed in the dev branch.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

torpy’s picture

torpy CreditAttribution: torpy commented
FileSize
smsframework-1923432-strict_error-7.patch693 bytes

It doesn't actually fix the problem. The issue is that the return from a function call is passed into array_shift().

Patch attached.

torpy’s picture

torpy CreditAttribution: torpy commented
Status: Closed (fixed) » Needs review

Forgot issue status!

  • Commit 2e5eda6 on 7.x-1.x by almaudoh: 
    Issue #1923432 by torpy | phillipclarke29: Fixed Error message when...
almaudoh’s picture

almaudoh CreditAttribution: almaudoh commented
Issue summary: View changes
Status: Needs review » Fixed

Committed and pushed to 7.x-1.x. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.