Files: 
CommentFileSizeAuthor
#7 system_config_form-1924990-7.patch2.37 KBtim.plunkett
PASSED: [[SimpleTest]]: [MySQL] 58,146 pass(es).
[ View ]

Comments

Issue summary:View changes

assigning user to me

Issue summary:View changes

removed stray *

Issue tags:+FormInterface

Okay, I did user and aggregator as examples.

All conversions should use routes and be defined as a service ID, so that config.factory can be injected in.
Aggregator has the additional example of how to inject other dependencies.

Issue summary:View changes

added aggregator issue

Issue summary:View changes

added book

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

I don't want to convert any more routes as services until #1915774: Decide whether core route controllers should generally/always be DIC services or not is resolved. This is exactly the sort of service bloat I'm concerned about in the other issue.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

added search

Issue tags:+Novice

ok. 1915774 was committed. it's waiting on a change notice, so that's why it's open. We can proceed creating the rest of the conversion issues. Since there are examples already, I'm tagging with novice.

When creating the issues, look at the examples already in the issue summary and be sure and update this issue summary and link the issues together.

Issue summary:View changes

Updated

Issue summary:View changes

Added simpletest issue.

Issue summary:View changes

Added simpletest issue properly

Issue summary:View changes

Add statistics issue.

Issue summary:View changes

Add update issue

Issue summary:View changes

Add link to the menu module issue.

Issue summary:View changes

Indicate the menu module issue is assigned to me.

I've rerolled aggregator, update and user (#1925048-6: Convert aggregator's system_config_form() to SystemConfigFormBase, #1937998-2: Convert update's system_config_form() to SystemConfigFormBase and #1924992-9: Convert user's system_config_form() to SystemConfigFormBase) to account for #1934832: Provide a dedicated approach for using forms in routes which got committed in the meantime.

All the other patches need to follow the new pattern for converting forms, the main difference being that you no longer have to create a service for each form class. More details and examples are in #1934832: Provide a dedicated approach for using forms in routes.

Issue tags:+#SprintWeekend

Add sprintweekend tag.

Issue summary:View changes

Add locale issue.

Status:Active» Needs review
StatusFileSize
new2.37 KB
PASSED: [[SimpleTest]]: [MySQL] 58,146 pass(es).
[ View ]

We can now kill off system_config_form()! Yay

Status:Needs review» Reviewed & tested by the community

Yay!!

Title:[meta] Convert all of system_config_form() to SystemConfigFormBaseChange notice: [meta] Convert all of system_config_form() to SystemConfigFormBase
Priority:Major» Critical
Status:Reviewed & tested by the community» Active
Issue tags:+Needs change record

Title:Change notice: [meta] Convert all of system_config_form() to SystemConfigFormBase[meta] Convert all of system_config_form() to SystemConfigFormBase
Priority:Critical» Major
Status:Active» Fixed
Issue tags:-Needs change record

Automatically closed -- issue fixed for 2 weeks with no activity.