Files: 
CommentFileSizeAuthor
#15 book-1925196-15.patch6.03 KBrobmc
PASSED: [[SimpleTest]]: [MySQL] 52,588 pass(es).
[ View ]
#9 book-1925196-6.patch6.03 KBjoergM
FAILED: [[SimpleTest]]: [MySQL] Setup environment: Test cancelled by admin prior to completion.
[ View ]
#6 book-1925196-5.patch6.62 KBjoergM
FAILED: [[SimpleTest]]: [MySQL] Setup environment: Test cancelled by admin prior to completion.
[ View ]
#4 book-1925196-4.patch7.48 KBtim.plunkett
PASSED: [[SimpleTest]]: [MySQL] 52,274 pass(es).
[ View ]
#2 book-1925196-2.patch7.38 KBtim.plunkett
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch book-1925196-2.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#1 book-1925196-1.patch20.79 KBtim.plunkett
PASSED: [[SimpleTest]]: [MySQL] 52,236 pass(es).
[ View ]

Comments

Status:Active» Needs review
StatusFileSize
new20.79 KB
PASSED: [[SimpleTest]]: [MySQL] 52,236 pass(es).
[ View ]

StatusFileSize
new7.38 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch book-1925196-2.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Those other issues were committed.

Status:Needs review» Needs work

The last submitted patch, book-1925196-2.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new7.48 KB
PASSED: [[SimpleTest]]: [MySQL] 52,274 pass(es).
[ View ]

Status:Needs review» Needs work
Issue tags:+#SprintWeekend

StatusFileSize
new6.62 KB
FAILED: [[SimpleTest]]: [MySQL] Setup environment: Test cancelled by admin prior to completion.
[ View ]

Changed implementation of conversion book's system_config_form() to SystemConfigFormBase according to the implementation of #1925738: Convert language's system_config_form() to SystemConfigFormBase.
Use _form: 'Drupal\book\BookSettingsForm' instead of _controller: 'book.form.settings:getForm' in book.routing.yaml

Status:Needs work» Needs review

Needs review to trigger testbot

Status:Needs review» Needs work

+++ b/core/modules/book/lib/Drupal/book/BookSettingsForm.php
@@ -0,0 +1,101 @@
+  /**
+   * Stores the configuration factory.
+   *
+   * @var \Drupal\Core\Config\ConfigFactory
+   */
+  protected $configFactory;
+
+  /**
+   * Constructs a \Drupal\book\BookSettingsForm object.
+   *
+   * @param \Drupal\Core\Config\ConfigFactory $config_factory
+   *   The factory for configuration objects.
+   */
+  public function __construct(ConfigFactory $config_factory) {
+    $this->configFactory = $config_factory;
+  }
+
+  /**
+   * Returns an instance of this form.
+   */
+  public function getForm() {
+    return drupal_get_form($this);

All of these are not necessary anymore because the base class takes care of that. Also, don't forget to remove use Drupal\Core\Config\ConfigFactory; as well.

Status:Needs work» Needs review
StatusFileSize
new6.03 KB
FAILED: [[SimpleTest]]: [MySQL] Setup environment: Test cancelled by admin prior to completion.
[ View ]

Removal of superfluous ConfigFactory stuff according to amateescu review comment.

Looks great now! Thanks for the quick reroll :) Let's wait for the testbot before marking RTBC.

Issue tags:+WSCCI-conversion

+++ b/core/modules/book/book.module
@@ -145,12 +145,10 @@ function book_menu() {
-    'page callback' => 'drupal_get_form',
-    'page arguments' => array('book_admin_settings'),
+    'page callback' => 'NOT_USED',

As of last night, this should instead specify 'route' => 'book_settings' and then no page callback at all.

Status:Needs review» Needs work

Assigned:Unassigned» robmc

StatusFileSize
new6.03 KB
PASSED: [[SimpleTest]]: [MySQL] 52,588 pass(es).
[ View ]

re-rolled with route_name change.

Status:Needs work» Needs review

Assigned:robmc» Unassigned

Status:Needs review» Reviewed & tested by the community

And there was much rejoicing!

Status:Reviewed & tested by the community» Fixed

YAY! Great to see these patches starting to flow!

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.