Convert forum's system_config_form() to SystemConfigFormBase

The patch just wraps the ForumSettingsForm in an object and uses symfony routing. This results in cleaner and better code.

I applied the patch and checked the functionality. Everything seems to work and I'd say it is RTBC.

The problem is there doesn't seem to be any tests for the functionality controlled by this form. So I can't easily confirm this patch doesn't change anything. I'd say we need tests for this. Or maybe the whole functionality could / should be moved to views?

This needs to be rerolled to take advantage of the recent improvements to forms. See #1924990-5: [meta] Convert all of system_config_form() to SystemConfigFormBase

Hi Tim

I think it already uses the new version?

class ForumSettingsForm extends SystemConfigFormBase {

+++ b/core/modules/forum/forum.routing.ymlundefined
@@ -0,0 +1,6 @@
+  defaults:
+    _controller: 'forum.form.settings:getForm'

+++ b/core/modules/forum/lib/Drupal/forum/ForumBundle.phpundefined
@@ -0,0 +1,27 @@
+<?php
+
+/**
+ * @file
+ * Contains Drupal\forum\ForumBundle.
+ */
+
+namespace Drupal\forum;
+
+use Symfony\Component\DependencyInjection\ContainerBuilder;
+use Symfony\Component\DependencyInjection\Reference;
+use Symfony\Component\HttpKernel\Bundle\Bundle;
+
+/**
+ * Forum dependency injection container.
+ */
+class ForumBundle extends Bundle {
+
+  /**
+   * Overrides Symfony\Component\HttpKernel\Bundle\Bundle::build().
+   */
+  public function build(ContainerBuilder $container) {
+    $container->register('forum.form.settings', 'Drupal\forum\ForumSettingsForm')
+      ->addArgument(new Reference('config.factory'));
+  }
+

+++ b/core/modules/forum/lib/Drupal/forum/ForumSettingsForm.phpundefined
@@ -0,0 +1,101 @@
+use Drupal\Core\Config\ConfigFactory;
...
+  /**
+   * Stores the configuration factory.
+   *
+   * @var \Drupal\Core\Config\ConfigFactory
+   */
+  protected $configFactory;
+
+  /**
+   * Constructs a \Drupal\forum\ForumSettingsForm object.
+   *
+   * @param \Drupal\Core\Config\ConfigFactory $config_factory
+   *   The factory for configuration objects.
+   */
+  public function __construct(ConfigFactory $config_factory) {
+    $this->configFactory = $config_factory;
+  }
+
+  /**
+   * Returns an instance of this form.
+   */
+  public function getForm() {
+    return drupal_get_form($this);

All of this can go away, and just have _form: 'Drupal\forum\ForumSettingsForm' in the YAML file.

+++ b/core/modules/forum/forum.module
@@ -138,8 +138,7 @@ function forum_menu() {
-    'page callback' => 'drupal_get_form',
-    'page arguments' => array('forum_admin_settings'),
+    'page callback' => 'NOT_USED',
     'access arguments' => array('administer forums'),

The page callback is not necessary anymore, this should change to: 'route_name' => 'forum_settings'. And you can remove the access callback as well.

+++ b/core/modules/forum/forum.routing.yml
@@ -0,0 +1,6 @@
\ No newline at end of file

:)

Looks good now.

#10: forum-system-config-base-1925252.10.patch queued for re-testing.

Tested manually -- looks great. Submissions work fine.

Before:

After:

(Note: the different values are from me testing the submission.) ;)

Looks good!

Committed and pushed to 8.x. Thanks!