Files: 
CommentFileSizeAuthor
#33 system-1925660-33.patch68.04 KBtim.plunkett
PASSED: [[SimpleTest]]: [MySQL] 55,553 pass(es).
[ View ]
#33 interdiff.txt13.91 KBtim.plunkett
#31 system-1925660-31.patch67.5 KBtim.plunkett
FAILED: [[SimpleTest]]: [MySQL] 55,675 pass(es), 10 fail(s), and 1 exception(s).
[ View ]
#31 interdiff.txt16.56 KBtim.plunkett
#28 interdiff.txt2.79 KBheddn
#28 1925660-forminterface-system-drupal-28.patch62.78 KBheddn
FAILED: [[SimpleTest]]: [MySQL] 55,348 pass(es), 10 fail(s), and 1 exception(s).
[ View ]
#25 interdiff.txt16.31 KBheddn
#25 1925660-forminterface-system-drupal-25.patch65.52 KBheddn
FAILED: [[SimpleTest]]: [MySQL] 55,211 pass(es), 75 fail(s), and 7 exception(s).
[ View ]
#23 1925660-forminterface-system-drupal-23.patch62.33 KBmtift
PASSED: [[SimpleTest]]: [MySQL] 54,049 pass(es).
[ View ]
#22 1925660-forminterface-system-drupal-22.patch62.33 KBACF
PASSED: [[SimpleTest]]: [MySQL] 53,901 pass(es).
[ View ]
#20 1925660-forminterface-system-drupal-20.patch62.33 KBACF
FAILED: [[SimpleTest]]: [MySQL] 53,929 pass(es), 1 fail(s), and 3 exception(s).
[ View ]
#18 1925660-forminterface-system-drupal-18.patch62.4 KBACF
FAILED: [[SimpleTest]]: [MySQL] 53,935 pass(es), 2 fail(s), and 9 exception(s).
[ View ]
#17 1925660-17-missing_hunk.txt5.52 KBCottser
#16 1925660-forminterface-system-drupal-16.patch55.93 KBmtift
PASSED: [[SimpleTest]]: [MySQL] 53,638 pass(es).
[ View ]
#10 1925660-forminterface-system-drupal-10.patch61.38 KBACF
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1925660-forminterface-system-drupal-10.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#6 1925660-forminterface-system-drupal-6.patch61.38 KBACF
FAILED: [[SimpleTest]]: [MySQL] Drupal installation failed.
[ View ]
#4 1925660-forminterface-system-drupal-4.patch61.35 KBACF
FAILED: [[SimpleTest]]: [MySQL] 52,820 pass(es), 1 fail(s), and 0 exception(s).
[ View ]
#2 system-1925660-2.patch67.58 KBtim.plunkett
PASSED: [[SimpleTest]]: [MySQL] 52,220 pass(es).
[ View ]
#1 system-1921996-1.patch78.97 KBtim.plunkett
PASSED: [[SimpleTest]]: [MySQL] 52,262 pass(es).
[ View ]

Comments

Status:Active» Needs review
StatusFileSize
new78.97 KB
PASSED: [[SimpleTest]]: [MySQL] 52,262 pass(es).
[ View ]

StatusFileSize
new67.58 KB
PASSED: [[SimpleTest]]: [MySQL] 52,220 pass(es).
[ View ]

Assigned:tim.plunkett» Unassigned
Status:Needs review» Needs work
Issue tags:+#SprintWeekend

Status:Needs work» Needs review
StatusFileSize
new61.35 KB
FAILED: [[SimpleTest]]: [MySQL] 52,820 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

Updated.

Status:Needs review» Needs work

The last submitted patch, 1925660-forminterface-system-drupal-4.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new61.38 KB
FAILED: [[SimpleTest]]: [MySQL] Drupal installation failed.
[ View ]

Updated for 'route_name'.

Status:Needs review» Needs work
Issue tags:-FormInterface, -#SprintWeekend

The last submitted patch, 1925660-forminterface-system-drupal-6.patch, failed testing.

Status:Needs work» Needs review

#6: 1925660-forminterface-system-drupal-6.patch queued for re-testing.

Submitting for re-test as the repo failed to checkout from git.

Status:Needs review» Needs work
Issue tags:+FormInterface, +#SprintWeekend

The last submitted patch, 1925660-forminterface-system-drupal-6.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new61.38 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1925660-forminterface-system-drupal-10.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Updated, think I found the error.

Status:Needs review» Needs work
Issue tags:-FormInterface, -#SprintWeekend

The last submitted patch, 1925660-forminterface-system-drupal-10.patch, failed testing.

Status:Needs work» Needs review

#10: 1925660-forminterface-system-drupal-10.patch queued for re-testing.

Have gone for a retest because I can't replicate this issue locally. Although the three fails did relate to the admin page tests, which would definitely make sense.

Status:Needs review» Needs work
Issue tags:+FormInterface, +#SprintWeekend

The last submitted patch, 1925660-forminterface-system-drupal-10.patch, failed testing.

Assigned:Unassigned» mtift

Working on a re-roll

Status:Needs work» Needs review
StatusFileSize
new55.93 KB
PASSED: [[SimpleTest]]: [MySQL] 53,638 pass(es).
[ View ]

My first attempt at a re-roll using git merge

Status:Needs review» Needs work
StatusFileSize
new5.52 KB

Thanks @mtift! It looks like there is a hunk missing from the reroll, just a deletion (see attached). The difference in patch file size was my tip-off.

I did a git blame on system.admin.inc and saw that the conflict came from #1926228: Performance page provides incorrect/incomplete information about CSS and JS compression (first patch), so I think that committed string change should be made in this patch as well.

Status:Needs work» Needs review
StatusFileSize
new62.4 KB
FAILED: [[SimpleTest]]: [MySQL] 53,935 pass(es), 2 fail(s), and 9 exception(s).
[ View ]

re-rolled

Status:Needs review» Needs work

The last submitted patch, 1925660-forminterface-system-drupal-18.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new62.33 KB
FAILED: [[SimpleTest]]: [MySQL] 53,929 pass(es), 1 fail(s), and 3 exception(s).
[ View ]

Oops, think I spotted the mistake.

Status:Needs review» Needs work

The last submitted patch, 1925660-forminterface-system-drupal-20.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new62.33 KB
PASSED: [[SimpleTest]]: [MySQL] 53,901 pass(es).
[ View ]

Should pass now.

Assigned:mtift» Unassigned
StatusFileSize
new62.33 KB
PASSED: [[SimpleTest]]: [MySQL] 54,049 pass(es).
[ View ]

+++ b/core/modules/system/lib/Drupal/system/Form/CronForm.phpundefined
@@ -0,0 +1,125 @@
+use Drupal\Core\KeyValueStore\KeyValueFactory;
+use Symfony\Component\HttpFoundation\RedirectResponse;
+use Drupal\Core\Config\ConfigFactory;
+use Drupal\Core\Config\Context\ContextInterface;
+use Symfony\Component\DependencyInjection\ContainerInterface;

This is probably too nit picky, especially since #1624564: [policy] Coding standards for "use" statements (and elsewhere) discussed ordering "use statements" without coming to a resolution. That said, it seems like we could at least keep the Drupal and Symfony statements together, which is the only change in the attached patch.

The rest looks good to me, but I don't feel qualified to RTBC these.

Status:Needs review» Needs work

Close, some of this is just out of date due to other improvements.

+++ b/core/modules/system/lib/Drupal/system/Form/CronForm.phpundefined
@@ -0,0 +1,125 @@
+    $this->configFactory = $config_factory;
+    $this->configFactory->enterContext($context);

This should call parent::__construct()

+++ b/core/modules/system/lib/Drupal/system/Form/PerformanceForm.phpundefined
@@ -0,0 +1,142 @@
+    $config->set('cache.page.use_internal', $form_state['values']['cache']);
+    $config->set('cache.page.max_age', $form_state['values']['page_cache_maximum_age']);
+    $config->set('response.gzip', $form_state['values']['page_compression']);
+    $config->set('css.preprocess', $form_state['values']['preprocess_css']);
+    $config->set('js.preprocess', $form_state['values']['preprocess_js']);
+    $config->save();

This should use the chained approach, you don't need the $config variable.

+++ b/core/modules/system/lib/Drupal/system/Form/PerformanceForm.phpundefined
@@ -0,0 +1,142 @@
+    cache('page')->deleteAll();

This should have the cache() injected, or at least \Drupal::cache().

+++ b/core/modules/system/lib/Drupal/system/Form/SystemFormBase.phpundefined
@@ -0,0 +1,43 @@
+abstract class SystemFormBase extends SystemConfigFormBase implements ControllerInterface {
+
+  /**
+   * Constructs a \Drupal\language\Form\LanguageFormBase object.
+   *
+   * @param \Drupal\Core\Config\ConfigFactory $config_factory
+   *   The factory for configuration objects.
+   * @param \Drupal\Core\Config\Context\ContextInterface $context
+   *   The configuration context used for this configuration object.
+   */
+  public function __construct(ConfigFactory $config_factory, ContextInterface $context) {
+    $this->configFactory = $config_factory;
+    $this->configFactory->enterContext($context);
+  }
+
+  /**
+   * Implements \Drupal\Core\ControllerInterface::create().
+   */
+  public static function create(ContainerInterface $container) {
+    return new static(
+      $container->get('config.factory'),
+      $container->get('config.context.free')
+    );
+  }
+
+}
diff --git a/core/modules/system/system.admin.inc b/core/modules/system/system.admin.inc

This can all go away, this was moved into SystemConfigFormBase directly

+++ b/core/modules/system/system.moduleundefined
@@ -802,11 +802,9 @@ function system_menu() {
     'access arguments' => array('administer site configuration'),

Here, and all of the rest, don't need access arguments anymore

StatusFileSize
new65.52 KB
FAILED: [[SimpleTest]]: [MySQL] 55,211 pass(es), 75 fail(s), and 7 exception(s).
[ View ]
new16.31 KB

Status:Needs work» Needs review

Status:Needs review» Needs work

The last submitted patch, 1925660-forminterface-system-drupal-25.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new62.78 KB
FAILED: [[SimpleTest]]: [MySQL] 55,348 pass(es), 10 fail(s), and 1 exception(s).
[ View ]
new2.79 KB

It would appear that the date configuration isn't included in the conversion effort on this issue. Let's try testing things again.

Status:Needs review» Needs work

The last submitted patch, 1925660-forminterface-system-drupal-28.patch, failed testing.

Assigned:Unassigned» tim.plunkett

Adding system_image_toolkit_settings since it was added in #1664844: Convert image toolkits into plugins

Status:Needs work» Needs review
StatusFileSize
new16.56 KB
new67.5 KB
FAILED: [[SimpleTest]]: [MySQL] 55,675 pass(es), 10 fail(s), and 1 exception(s).
[ View ]

The last config form in system.module is taken care of by #1992606: Convert system_theme_settings to FormInterface

Status:Needs review» Needs work

+++ b/core/modules/system/lib/Drupal/system/Form/CronForm.phpundefined
@@ -0,0 +1,126 @@
+  protected $store;
...
+    $this->state = $key_value_factory->get('state');

so is it state not store:)

+++ b/core/modules/system/lib/Drupal/system/Form/CronForm.phpundefined
@@ -0,0 +1,126 @@
+      '#submit' => array(array($this, 'submitCron')),
+++ b/core/modules/system/lib/Drupal/system/Form/PerformanceForm.phpundefined
@@ -0,0 +1,145 @@
+      '#submit' => array(array($this, 'submitCacheClear')),
...
+    $form['#submit'][] = array('systemClearPageCacheSubmit');
+    $form['#submit'][] = array('submitForm');

oh, does this finally work? am i outdated?:P

+++ b/core/modules/system/lib/Drupal/system/Form/PerformanceForm.phpundefined
@@ -0,0 +1,145 @@
+    drupal_add_library('system', 'drupal.system');

i wonder if we could use #attached here on the $form instead

+++ b/core/modules/system/lib/Drupal/system/Form/PerformanceForm.phpundefined
@@ -0,0 +1,145 @@
+    \Drupal::cache('page')->deleteAll();

cant we inject this?

+++ b/core/modules/system/lib/Drupal/system/Form/SiteInformationForm.phpundefined
@@ -0,0 +1,147 @@
+      form_set_value($form['front_page']['site_frontpage'], drupal_container()->get('path.alias_manager')->getSystemPath($form_state['values']['site_frontpage']), $form_state);
...
+      form_set_value($form['error_page']['site_403'], drupal_container()->get('path.alias_manager')->getSystemPath($form_state['values']['site_403']), $form_state);
...
+      form_set_value($form['error_page']['site_404'], drupal_container()->get('path.alias_manager')->getSystemPath($form_state['values']['site_404']), $form_state);

inject path alias manager?

+++ b/core/modules/system/system.moduleundefined
@@ -1023,20 +996,17 @@ function system_menu() {
-    'access arguments' => array('administer site configuration'),
...
   $items['admin/reports/status/run-cron'] = array(
...
-    'access arguments' => array('administer site configuration'),
...
   $items['admin/reports/status/php'] = array(
...
-    'access arguments' => array('administer site configuration'),

i cant see why those are removed

Status:Needs work» Needs review
StatusFileSize
new13.91 KB
new68.04 KB
PASSED: [[SimpleTest]]: [MySQL] 55,553 pass(es).
[ View ]

Thanks @ParisLiakos!

Status:Needs review» Reviewed & tested by the community

looks awesome now
also manually tested, and everything looks good
thanks!

Status:Reviewed & tested by the community» Fixed

Committed/pushed to 8.x, thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.