Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#14 | language-1925738-14.patch | 1.33 KB | tim.plunkett |
#9 | 1925738-test-run.png | 42.05 KB | Kars-T |
#8 | language-1925738-8.patch | 22.66 KB | tim.plunkett |
#7 | language-1925738-7.patch | 44.68 KB | tim.plunkett |
#7 | interdiff.txt | 7.43 KB | tim.plunkett |
Comments
Comment #1
tim.plunkettIncludes #1921996: Convert system_config_form() to implement FormInterface as a base class. and #1925140: drupal_form_submit() does not accept FormInterface objects
Comment #3
tim.plunkettCopy/paste fail on my part.
Comment #4
tim.plunkettThose other issues were committed.
Comment #6
tim.plunkett#4: language-1925738-4.patch queued for re-testing.
Comment #7
tim.plunkettNow includes #1934832: Provide a dedicated approach for using forms in routes
I added a base class to cut down on copy/paste, but its much better with the _form in routing.yml and the ControllerInterface.
Comment #8
tim.plunkettOkay! Everything is finally in.
Comment #9
Kars-T CreditAttribution: Kars-T commentedThe patch is rather basic as it encapsulates stuff from language.admin.inc in new SystemConfigFormBase objects and uses the symfony routing system. The source this way is much cleaner and easier to read. I checked if it uses the same config names and let the tests runs. They finished without any problems.
To me the changes make sense and as the tests don't show any errors I'd say it is rtbc.
Comment #10
webchick#8: language-1925738-8.patch queued for re-testing.
Comment #11
alexpott#8: language-1925738-8.patch queued for re-testing.
Comment #12
alexpottCommitted and pushed to 8.x. Thanks!
Comment #13
andypostIs not it needs follow-up to clean-up? Why "route name" is not used?
Comment #14
tim.plunkettYep, that changed since March 8th when I wrote this :)
Comment #15
andypostSuppose bot would be green!
Comment #16
alexpottCommitted c0eaf0f and pushed to 8.x. Thanks!