With the recent addition of modernizr_modernizr_info_alter in #1569398: "Download Modernizr" link on the settings page should include all tests currently within the JS file, there is no distinction in the interface between the Modernizr tests requested by the themes and modules and those available in the installed modernizr JS file.

I propose two sub-sections in the Modernizr settings admin page, separated by headings: "Requested Modernizr Tests" and "Available Modernizr Tests", where the former refers to those tests requested by the modules and themes, and the latter refers to those tests available in the current JS file.

If there is agreement, I can submit a patch.

Comments

mmikitka’s picture

Assigned: mmikitka » Unassigned
rupl’s picture

Title: Modernizr settings Admin Page: Create "Requested" and "Available" Sub-sections » Admin config: clearly denote which tests came from an existing copy of modernizr.js
Component: Code » User interface

The core issue is that it's not plainly obvious that some tests come from the active modernizr.js file.

Right now there's no way to distinguish where something came from other than the "source" value of a given test. The modernizr_modernizr_info_alter() function defines its source as "Modernizr (existing test)" — it is this title which seems to be causing the confusion.

Since we are the only module that needs to peek inside modernizr.js, I think creating Requested/Available subsections is overkill. It would be simpler to rename the source attribute to be more obvious. I do not want to remove the word Modernizr because that is the module supplying the test requests. Perhaps renaming that last phrase in parentheses will be easiest?

Some random ideas:

  • Modernizr (current custom build)
  • Modernizr (currently included)
  • Modernizr (found within modernizr.js)
mmikitka’s picture

Component: User interface » Code
Assigned: Unassigned » mmikitka

rupl, I vote for "Modernizr (available in custom build)" or "Modernizr (current custom build)"

rupl’s picture

what about "Modernizr (found within modernizr.js)"

rupl’s picture

Status: Active » Fixed

I committed the label in comment #4, except it actually prints the filename it finds. I think it's pretty clear now. Thanks for bringing this up and don't hesitate to bring up any other pain points in the UI.

http://drupalcode.org/project/modernizr.git/commitdiff/20f626e

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.