Problem/Motivation
When adding the Find Replace plugin, a typo in the description of "Match whole word/phrase" in the "configure" text contradicts itself and makes it unclear what the effect of selecting the "Match whole word/phrase" checkbox will be:
If checked, then the whole word or phrase will be matched, e.g. "book" will match not match "book" in "the book".
Steps to reproduce:
- Go to admin/structure/feeds/tamper/list/[name-of-your-feed].
- Click the 'Add plugin' link below a mapping.
- Click the 'The plugin to add' dropdown.
- Select 'Find replace' (in the 'Text' category).
- Scroll down if necessary and read the description for the 'Match whole word/phrase' option.
Proposed resolution
Change that portion of the "Match whole word/phrase" UI text to read:
If checked, then the whole word or phrase will be matched, e.g. "book" will not match "book" in "the book".
Remaining tasks
- Confirm that the proposed text ("not match") accurately describes the actual behavior.
- Review the patch.
User interface changes
Change that portion of the "Match whole word/phrase" UI text to read:
If checked, then the whole word or phrase will be matched, e.g. "book" will not match "book" in "the book".
API changes
None.
Comment | File | Size | Author |
---|---|---|---|
#1 | feeds_tamper-fix_match_not_match_contradiction_in_find_replace-1928154-1.patch | 875 bytes | fureigh |
Comments
Comment #1
fureigh CreditAttribution: fureigh commentedPatch attached, rolled against the master branch.
Comment #2
twistor CreditAttribution: twistor commentedI changed the wording a bit.
Thanks!
http://drupalcode.org/project/feeds_tamper.git/commit/1469a32
Comment #2.0
twistor CreditAttribution: twistor commentedUpdated remaining steps.
Comment #4
twistor CreditAttribution: twistor commented