I was successfully using Feeds Tamper Beta 4 with Feeds 7x-2.0 alpha 5, but when I updated to Feeds alpha 7, it stopped working. On the edit tab for my feed importer, when I click Configure Feeds Tamper, it tries to load it into the existing UI (which would be a lot nicer than flipping to a separate page like it did before), but then the Feeds Tamper UI never loads.

Additionally, when I look at the settings on the left hand side, it has reset them and started a new importer, it seems.

Comments

Mark F’s picture

Mark F commented

Also getting this problem with same versions.

behindthepage’s picture

behindthepage commented

The problem is in line 136 of feeds_tamper_ui.module

It looks like $form['#importer']->id has been changed to just $form['#importer']

The following code works for me

function feeds_tamper_ui_form_feeds_ui_mapping_form_alter(&$form, &$form_state) {
  if (feeds_tamper_access($form['#importer'])) {
    $form['help']['#markup'] .= l(t('Configure Feeds Tamper'), FEEDS_TAMPER_UI_BASE . '/list/' . $form['#importer']);
  }
}
jackhutton’s picture

jackhutton commented

having this issue as well.. tried a hack edit at line 136 of feeds_tamper_ui.module but so far not successful.
not a big coder, here, how did you integrate your code? did you remove lines .. or just drop this in? Thanks..

jackhutton’s picture

jackhutton commented

Resolved this by updating the feeds module to 7.x-2.x-dev along with the Feeds tamper 7.x-1.x-dev & looks great.. thanks for the improvements & work,.

rvdtuin’s picture

rvdtuin commented

#3 to jackhutton
I removed the ->id from line 136, flushed the caches and it works.

Mark Vincent Verallo’s picture

Mark Vincent Verallo commented

#5 fixed it for me.

jackhutton’s picture

jackhutton commented

thank rvdtuin - I'll return to this and try that out.. appreciate your feedback.

jackhutton’s picture

jackhutton commented

thanks again rvdtuin - seems #5 fixed it..

kingandy’s picture

kingandy
he/him
commented

Yep, #5 is what I did too!

Mark Vincent Verallo’s picture

Mark Vincent Verallo commented

But better upgrade to the latest dev versions of both. I did it!

kingandy’s picture

kingandy
he/him
commented

On a side note, it would make more sense for the URL to be admin/structure/feeds/$id/tamper - then the menu item could be made available in a number of natural Drupal ways (ie as a local action or tab) instead of injected into the page structure like this. I don't know if that counts as a separate issue or not (I guess it would be a Feature Request rather than a bug - this bug is technically resolved with this workaround).

It would also be great if it could be attached to the sidebar menu, but that's definitely a separate issue...

twistor’s picture

twistor commented
Status: Active » Fixed

@kingandy

It's been a tab for a while. I needed to change some things in Feeds for it to work.

This is fixed, rolling a new release soon to take care of any loose ends.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.