Hello,
I just installed the module and it seems to work fine for me. However, I am using it with Advanced Forum which uses buttons to reply/modify/delete. I would have liked to theme the quote link the same way...

See example of what I am talking about here:
http://www.coryphee.ch/forum/forums/maud-aka-calamity-jenni

CommentFileSizeAuthor
#5 quote-advancedforum-1929658-5.patch2.06 KBdiscipolo
#2 1929658_quote_button_proper_place.patch2.52 KBNikita Petrov
#1 quote_button_proper_place_1929658_1.patch2.13 KBNikita Petrov
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Nikita Petrov’s picture

Nikita Petrov CreditAttribution: Nikita Petrov commented
Version: 7.x-1.1-beta2 » 7.x-1.x-dev
Status: Active » Needs review
FileSize
quote_button_proper_place_1929658_1.patch2.13 KB

Here is a patch for this problem.
Description: $object->content['links']['comment'] is exists everywhere - at the node and at the comments too. Advanced forum using exactly the same array, so i changed the position from $object->content['links']['quote']['#links']['quote'] to $object->content['links']['comment']['#links']['quote'] and now it works fine - "Quote" button is styled properly.
Also i made some code optimizations to avoid duplication of code (moved code to quote_add_quote_link function)

Nikita Petrov’s picture

Nikita Petrov CreditAttribution: Nikita Petrov commented
Version: 7.x-1.x-dev » master
FileSize
1929658_quote_button_proper_place.patch2.52 KB

Here is the same patch as above, but for using "git am" command, to avoid problems with differences between the branches. I'm using the branch "master", is it right?

A-snowboard’s picture

A-snowboard CreditAttribution: A-snowboard commented

Hello,

Thank you for your V2 patch. It works well for me at first.

I did further testing.

Thank you very much.

(Sorry for writing, google translate is my friend)

No Sssweat’s picture

No Sssweat CreditAttribution: No Sssweat commented
Version: master » 7.x-1.1-beta2
Status: Needs review » Reviewed & tested by the community

Worked for me perfectly. Thanks for the patch, hopefully they'll add this in the next release.

discipolo’s picture

discipolo CreditAttribution: discipolo commented
Version: 7.x-1.1-beta2 » 7.x-1.x-dev
FileSize
quote-advancedforum-1929658-5.patch2.06 KB

here is the patch against 7.x-1.x

Luneh’s picture

Luneh CreditAttribution: Luneh commented

Sorry for thanking you so late...
Thank you!

AlfTheCat’s picture

AlfTheCat CreditAttribution: AlfTheCat commented
Issue summary: View changes

Awesome! Thanks!

MXT’s picture

MXT
Primary language Italian
Location Milan
CreditAttribution: MXT commented

Patch provided in #5 works very well also for me, thank you.

kopeboy’s picture

kopeboy CreditAttribution: kopeboy commented

Was this included anywhere?

No Sssweat’s picture

No Sssweat CreditAttribution: No Sssweat commented

@Kopeboy, nope, 7.x-1.1-beta2 doesn't have it, I had to use the patch. See comment #4.

  • Zen committed 3760505 on 7.x-1.x 
    Issue #1929658 by Nikita Petrov, Zen: Quote button to match Advanced...
Zen’s picture

Zen CreditAttribution: Zen commented

Committed a slightly modified patch. Thanks to everybody.

-K

Zen’s picture

Zen CreditAttribution: Zen commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.