Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Layouts currently don't render region wrappers around the various regions. This will be problematic as we move to migrating existing theme page templates to layout plugins. Layouts are also treating the output as strings, and I'm pretty sure they should be arrays.
Eclipse
Comment | File | Size | Author |
---|---|---|---|
#3 | 1929682-3.patch | 7.26 KB | EclipseGc |
#1 | 1929682-1.patch | 3.12 KB | EclipseGc |
Comments
Comment #1
EclipseGc CreditAttribution: EclipseGc commentedand a patch.
Comment #3
EclipseGc CreditAttribution: EclipseGc commentedok, let's see if this passes now.
Comment #4
Gábor Hojtsy<div class="layout-region ..
is already the region wrapper, no? Adding one more wrapper does not sound like very efficient. What about making it possible to add classes on the existing region wrapper instead?Comment #5
EclipseGc CreditAttribution: EclipseGc commentedActually the problem here is that in the bartik conversion, none of the regions have a region wrapper because it's added on programmatically somewhere else. I'm open to ideas here, but we should either manually add region wrappers in the bartik tpl, or we should remove the regions wrappers from our existing layout plugins. I'm fine with either solution. Thoughts?
Eclipse
Comment #6
Gábor HojtsyWe can remove the existing region wrappers from the layout templates. I don't think duplicate region wrappers is a good idea. I smell divitis there.
Comment #7
EclipseGc CreditAttribution: EclipseGc commentedYeah, I think that's the right solution too, I worry about people wanting to get rid of the regions wrappers though. :-S
Comment #8
webchickLayout module got removed from core, so moving this over here instead.