In some cases it would be useful to be able to disable the effect on certain paths, on admin pages and when overlay is opened for example
But also when an exposed filter block sends a user to a view page from another page. It looks weird to submit a form on the front page and to get an ajax like spinner before being taken to a different page. So being able to set the effect to be active on certain pages could be a welcome feature.
Comment | File | Size | Author |
---|---|---|---|
#13 | interdiff-9-12.txt | 2.7 KB | anavarre |
#13 | 1929806-12.patch | 8.69 KB | anavarre |
#10 | interdiff-8-9.txt | 4.88 KB | anavarre |
#10 | 1929806-9.patch | 8.41 KB | anavarre |
#8 | interdiff-7-8.txt | 1.28 KB | anavarre |
Comments
Comment #1
anavarreFeature requests should now be filed against 8.x-1.x-dev.
This is certainly a good idea. Will work towards implementing that soon.
Comment #2
anavarreComment #3
anavarreComment #4
joshi.rohit100What about adding setting on SettingsForm which allows enable/disable on paths (similar like blocks) ?
Comment #5
anavarreWe tried to think about what to do and wondered how easy it'd be to reuse the Block visibility feature. Turns out it's not meant to be easily reuseable :-( It's also what http://drupal.stackexchange.com/questions/187574/reuse-blocks-visibility... seems to suggest.
We thus tried to mimic what
RequestPath.php
does, which seemed to do the trick in a simple PoC without the actual logic in place.Comment #6
anavarreIn its most basic form, here's the idea as explained above: start reusing
RequestPath.php
The attached path is nowhere close to being usable. It only gives us the needed FAPI elements and leverages CM for storing values.
Next up we need to create tests and the actual logic to be reused from
RequestPath.php
. Work in progress. Stay tuned.Comment #7
anavarreNow with tests.
Comment #8
anavarreTo improve the UX, let's add a fieldset.
Comment #10
anavarreWorked with Dom. to implement more of
RequestPath.php
. Nothing usable yet.Comment #11
Ahmad Abbad CreditAttribution: Ahmad Abbad as a volunteer commentedAfter apply this patch i have this error
in (page_load_progress.module).
the public keyword is used only in function/variable declarations from within a class. Since you're not using a class you need to remove it from your code.
Comment #12
anavarre@Ahmad - Yes, as said above this is not usable code yet. Will post something usable soon.
Comment #13
anavarreOkay. This should now work, so marking as needs review to trigger the tests. Also filed a follow-up to get the ball rolling once this gets committed: #2824476: Follow-up for #1929806: create BrowserTestBase tests
Comment #15
anavarreLet's call this fixed. If there's any issue we can file a follow-up issue. See you in #2824476: Follow-up for #1929806: create BrowserTestBase tests for automated testing.