Update PIFR to use config to set simpletest verbose for D8 tests. [#1931574]

Currently, D8 tests have all sorts of verbose messages included, which is causing tests to reach the max assertion limit and hiding certain failures.

PIFR attempts to turn off verbose mode using direct database manipulation (simulating a variable_set()).

We now need to use CMI approaches to set this ... but with D6 functions. (ugh.)

Suggested approach is to write $conf['simpletest.settings']['verbose'] = 0 to settings.php on any D8 checkout.

Alternatively, we could try and find the simpletest.settings.yml file and edit it there, which will have to occur after simpletest is installed. The file will be located in a directory with a random component to the name, and settings.php will contain information regarding where that directory exists.

Comment	File	Size	Author
#1	pifr_config.patch	1.82 KB	jthorson

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

jthorson CreditAttribution: jthorson commented 3 March 2013 at 02:38

File	Size
pifr_config.patch	1.82 KB

Patch attached.

Comment #2

jthorson CreditAttribution: jthorson commented 3 March 2013 at 05:36

Okay ... need to move the commands out of the if () condition, for starters.

But also, the settings.php file has read permissions only, so opening for append presumably fails. I say presumably, because I'm not seeing the error that I expect to see dumped in the apache logs ... but the variable doesn't get written to the file.

Comment #3

Berdir

German

Switzerland

CreditAttribution: Berdir commented 3 March 2013 at 16:46

+++ b/review/drupal/pifr_drupal.client.incundefined
@@ -357,4 +357,27 @@ class pifr_client_review_pifr_drupal extends pifr_client_review {
+  protected function conf_set($setting, $name, $value) {
+    // Prepare the string
+    if (is_int($value)) {
+      $string = "\n" . '$conf' . "['$setting']['$name'] = $value;\n";
+    }
+    else {
+      $string = "\n" . '$conf' . "['$setting']['$name'] = '$value';\n";

If you want a re-usable function, it probably makes more sense to use something like array $settings_keys and then loop over it/implode it.

To override e.g. config('simpletest.settings')->get('something.bla'); the $conf syntax would be $conf['simpletest.settings']['something']['bla'].

Also not sure about function name, config_write_override() or something like that would be a bit more self-speaking, I also have an issue to rename $conf to $config_override.