First of all, thanks for this theme. It inspired me to finally re-launch my tiny web development blog.

I like to use <pre><code> for multiline code blocks. Doing so causes the code snippet styles to run amok, particularly the more colourful ones. The fix for the Simple style is easy, just add a declaration like this:

pre code { padding: 0; }

The other styles are more complex due to the background colours and so on.

References:
http://www.w3.org/TR/html5/grouping-content.html#the-pre-element
http://stackoverflow.com/questions/11742907/why-does-html5-recommend-put...

With just <pre>:
writer-pre.png

With <pre><code>:
writer-pre-code.png

CommentFileSizeAuthor
writer-pre-code.png111.5 KBstar-szr
writer-pre.png116.98 KBstar-szr
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bryanbraun’s picture

Assigned: Unassigned » bryanbraun
Status: Active » Fixed

Thanks for the detailed bug report (links, screenshots, and everything!). I've updated the CSS files and fixed the issue in the latest dev branches of 6.x-1.x and 7.x-1.x.

star-szr’s picture

Thanks! I have a couple more issues to post (with patches), and the way you handled this one is really encouraging :)

star-szr’s picture

By the way, it's good form the cite the issue # in your commits, Dreditor helps with this by providing a "Create commit message" button. This provides a good base for your commit messages.

bryanbraun’s picture

Status: Fixed » Closed (fixed)

Thanks for the advice. And feel free to post more issues (and patches) as you find rough spots in the theme. Closing this issue as fixed.

bryanbraun’s picture

Issue summary: View changes

Add thank you :)