Allow date/time to be set when manually changing a payment's status

CommentFileSizeAuthor
#9 payment_1932430_9.patch17.59 KBXano
#4 payment_1932430_4.patch8.39 KBXano
#3 payment_1932430_3.patch12.08 KBXano
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented
Version: 7.x-1.x-dev » 8.x-2.x-dev
Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented
Title: Allow date/time to be set when manually changing a payment's status » Add a payment_status element

Convert this to a form element for easy re-use.

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented
Title: Add a payment_status element » Add a payment_status_input element
Status: Active » Needs work
FileSize
payment_1932430_3.patch12.08 KB

This is a first stab, but the datetime element's validation keeps failing.

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented
Title: Add a payment_status_input element » Add a payment status update page
Issue summary: View changes
Status: Needs work » Needs review
FileSize
payment_1932430_4.patch8.39 KB

Let's do it like this instead. Making this a separate operation makes clear that by setting a new status the actual payment is not changed, but that its state changes. As a follow-up, change the existing payment edit form in #2252765: Expand the payment edit form.

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented

Note that when clicking the "Update status" operation from the payment entity list, the form should be opened in a modal, but that does not happen yet.

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented

And this needs tests...

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented

The problem was that the core/drupal.ajax library was not added to the page. Instead of doing this ourselves, wait for #2253257: Use a modal for entity delete operation links to be fixed.

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented

Also use ContentEntityForm instead of EntityForm.

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented
FileSize
payment_1932430_9.patch17.59 KB
Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented
Status: Needs review » Fixed

  • Commit 7ce9832 on 8.x-2.x by Xano: 
    Issue #1932430: Add a payment status update page.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.