When you have a view the contextual links don't work anymore.

The hover itself still does work, though the contextual js kicks in too fast.

Files: 
CommentFileSizeAuthor
#21 vdc-1933426-21.patch529 bytesdawehner
PASSED: [[SimpleTest]]: [MySQL] 56,974 pass(es).
[ View ]
#17 drupal-1933426-17.patch526 bytesdawehner
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch drupal-1933426-17.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#1 drupal-1933426-1.patch1.09 KBdawehner
PASSED: [[SimpleTest]]: [MySQL] 52,267 pass(es).
[ View ]

Comments

Status:Active» Needs review
StatusFileSize
new1.09 KB
PASSED: [[SimpleTest]]: [MySQL] 52,267 pass(es).
[ View ]

Let's move the contextual links js to hook_library_info and fix the order.

Status:Needs review» Reviewed & tested by the community

without the patch contextual links wouldnt fire..now works as should.
also +1 to have them as library

Status:Reviewed & tested by the community» Needs work
Issue tags:-VDC

The last submitted patch, drupal-1933426-1.patch, failed testing.

Status:Needs work» Needs review

#1: drupal-1933426-1.patch queued for re-testing.

Status:Needs review» Needs work

The last submitted patch, drupal-1933426-1.patch, failed testing.

Status:Needs work» Needs review
Issue tags:+VDC

#1: drupal-1933426-1.patch queued for re-testing.

Status:Needs review» Reviewed & tested by the community

now that bot agrees

Status:Reviewed & tested by the community» Fixed

Yay!

Committed and pushed to 8.x. Thanks!

Status:Fixed» Needs review

Do you think we should look at moving this into views_ui module instead? Seems it might be better living in there, as that's when we are using them.

Not sure, as this adds support for all kind of contextual links, not just edit view, at least in theory.

Status:Needs review» Fixed

Hmm, true. I remember now. I guess you could use them to add filters etc.. I think we could still move all of this into the UI though?

Let's fix this again (sorry) and create a followup?

Yeah, so views_ui is one of these modules that want to add new contextual links to it.

If a custom weight is necessary, then it should be documented *why*. Otherwise, we end up with unintelligible loading order/dependencies.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Priority:Normal» Minor
Status:Closed (fixed)» Active

(Sorry for reopening this issue.)

This patch moved the .js file into a library. Yay!

But, it failed to move the weight comment along with it. Look at the patch in #1: the weight comment at the top makes no sense anymore, it should be moved into the library definition.

Status:Active» Needs review
StatusFileSize
new526 bytes
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch drupal-1933426-17.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Well, the problem is a bit tricky here.

Even this actually "depends on contextual.js" this file has to be loaded before, as it alters some css classes in order to work properly,
so what about documenting this.

Title:Fix contextual links on views[Followup] Fix contextual links on views

Please open new issues for followups in the future. :) I had to read this whole issue to figure out it had nothing to do with what I was trying to find an issue for.

Issue tags:-VDC

#17: drupal-1933426-17.patch queued for re-testing.

Status:Needs review» Needs work
Issue tags:+VDC

The last submitted patch, drupal-1933426-17.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new529 bytes
PASSED: [[SimpleTest]]: [MySQL] 56,974 pass(es).
[ View ]

just a reroll.

Status:Needs review» Reviewed & tested by the community

Looks fine.

Status:Reviewed & tested by the community» Fixed

That works, but doesn't solve the problem pointed out in #16, which is that we need to remove the comment from above the line that is now just drupal_add_library(...) without any specialness about weights.

So I went ahead and did that as well and then committed/pushed #21 to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.