In the admin interface there are some links that have hardcoded urls.
Eg: <a href="/admin/config/services/twitter/settings">Twitter Settings</a>
Solution: url function should be used and added as a variable for t function.
There are some strings that are sent to t function and use p tag inside.
Eg: <p>You need to authenticate at least one Twitter account in order to use the Twitter API. Please fill out the OAuth fields at <a href="/admin/config/services/twitter/settings">Twitter Settings</a> and then return here.</p>
Solution: p tag should be moved outside.
I used http://drupal.org/node/322774 for reference.
The problem is that if we change those strings we might break translations.
I'll post a patch anyway.
Comment | File | Size | Author |
---|---|---|---|
#8 | twitter-fix-urls-1933908-7.patch | 2.69 KB | mfernea |
#3 | twitter-fix-urls-1933908-3.patch | 2.86 KB | mfernea |
#1 | twitter-fix-urls-1933908-1.patch | 2.95 KB | mfernea |
Comments
Comment #1
mfernea CreditAttribution: mfernea commentedThis is the patch.
Comment #2
joachim CreditAttribution: joachim commentedI'm pretty sure having the $text outside of the call to t() breaks translation tools.
Comment #3
mfernea CreditAttribution: mfernea commentedYes, you are right. Thanks!
I'm posting a new patch.
Comment #4
juampynr CreditAttribution: juampynr commentedCommitted, thanks!
http://drupalcode.org/project/twitter.git/commit/e10a6bd
Comment #5
juampynr CreditAttribution: juampynr commentedPorted to 7.x-6.x
Comment #6
juampynr CreditAttribution: juampynr commentedPatches for 6.x-5.x are welcome.
Comment #7
mfernea CreditAttribution: mfernea commentedComment #8
mfernea CreditAttribution: mfernea commentedI'm posting a patch for 6.x-5.x branch.
Comment #9
juampynr CreditAttribution: juampynr commentedCommitted. Thanks!
http://drupalcode.org/project/twitter.git/commit/bd504fd