Part of meta issue #1926846: Extending gmap module *.tests. Catching test gaps.
Related issues
not yet
Problem/Motivation
For creating simpletests for
gmap_plugin_style_gmap.inc- mostly covered with tests, needs extending, checkinggmap_plugin_style_gmapextended.inc- mostly covered with tests, needs extending, checking #1934122-23: Gmap Views tests. Needs extending and fixing follow-ups - patch commited
we need helper module with all king of views variants which can be easy enabled in test. Thanks to @johnv for module. They are gmap_test and gmap_test_extended at gmap module root directory(hidden from administration modules as used only for testing)
This issue created for consolidating views exports that can be integrated into module afterwards and how-to`s initialize em for full gmap features working
Good to see here uploaded feature(in http://drupal.org/patch format) http://dgo.to/feature for Your config (node type + view) as starting point
- Upload Your working feature to /tests folder
- For those who familiar with simpletest tests - write tests for Your feature, extending /tests/gmap.test (or skip this if no)
- Create patch
- Upload patch into this issue with 'needs review' status
- Thanks!!!
We`ll commit it under Your credentials into repository
Proposed resolution
Extend commited tests
/gmap_test/tests/gmap_test.test
/gmap_test_extended/tests/gmap_test_extended.test
With Your specific checks and post patch here for review with status "needs review"
Remaining tasks
todo
Original report by @podarok
#1926846: Extending gmap module *.tests. Catching test gaps.
Follow up issues
#1938492: Undefined index: geofield
#1938634: Undefined index: iwq
#1938640: Undefined index: highlight_nodearg_color
#1938642: implode(): Invalid arguments passed
Comment | File | Size | Author |
---|---|---|---|
#32 | gmap.png | 169.14 KB | podarok |
#23 | 1934122-extending-gmap-23.patch | 50.48 KB | podarok |
#23 | interdiff.txt | 460 bytes | podarok |
#22 | 1934122-extending-gmap-22.patch | 51.08 KB | podarok |
#18 | 1934122-views-exports-for-tests-15.patch | 87.29 KB | podarok |
Comments
Comment #1
podarok@johnv can You help with this issue?
Possibly good to see here Your working views export with how-to reproduce it
Comment #2
podarokthis tag is for me )
Comment #3
johnvOK,
I can create a Feature , including a node type + views.
Comment #4
podarok#3 yup, wohoo
This is very nice point for starting test implementation
Comment #4.0
podarokUpdated issue summary.
Comment #4.1
podarokUpdated issue summary.
Comment #4.2
podarokUpdated issue summary.
Comment #4.3
podarokUpdated issue summary.
Comment #4.4
podarokadded some points
Comment #5
podarokany progress here?
Comment #6
johnvPlease find a Feature attached. As a version number, it contains the date, so it is easy to see the latest version.
Please remove the .txt extension before unzipping.
it contains:
1. 2 Notetypes: Place and person. The person has an Entity reference to a Place. A place has a Geofield, Location, Addressfield, lat/lon fields.
2. a Views views with 6 displays: 3 for Places, 3 for persons, + its reference to places.
testscript:
1. create some Places, and in each node, enter the lat/lon manually in three different fields. (I did not use Geocoder, since it complicates the feature)
Place Latitude Longitude
Amsterdam 52.368500 4.891130
Brussels 50.852100 4.355490
Paris 48.623800 2.429370
Berlin 52.508200 13.374700
2. Create some Persons with reference to places;
3. go to /admin/structure/block , move the blocks from to ;
4. Go to /gmap-test-places, and see all views in one list.
First results:
- Geofield's 'all textfields' widget is not working (out of scope, )
- Show " 'location' of a referenced entity" is not working: there is no choice in the Plugin.
Todo:
- Extend with user reference/node reference instead of Entity reference. But those are almost legacy modules, already
- Extend with a node id as an argument.
Comment #7
podarokwow, thanks a lot!!!
Comment #8
podarok#6 commited as initial
working on test
Comment #9
podarokstep 1
Comment #10
podarokfixing master
http://drupalcode.org/project/gmap.git/commit/b384bc2
http://qa.drupal.org/pifr/test/378628
Comment #11
podarokyet one step
Comment #12
podarokanother try
Comment #13
podarokanother try with reorganized files
Comment #14
podarokshould work now
Comment #15
podarokanother try
Comment #16
podarokstatus
Comment #17
podaroktag
Comment #18
podarokyet one try
Comment #20
podarokhttp://qa.drupal.org/pifr/test/462678
commited to dev
thans @johnv for help
Comment #20.0
podarokUpdated issue summary.
Comment #21
podarok#1938492: Undefined index: geofield follow-up due to new test coverage
Comment #21.0
podarokUpdated issue summary. Add follow-up
Comment #21.1
podarokUpdated issue summary.
Comment #22
podarokThese messages need follow-ups
tests for gmapextended views plugin style
bot?
Comment #23
podarokwoops
#22 comes with #1938492: Undefined index: geofield patch
removed
Comment #23.0
podarokup
Comment #23.1
podarokUpdated issue summary.
Comment #24
podarok#23 commited pushed to 7.x-2.x-dev
tagged 7.x-2.5-alpha2 release
Comment #24.0
podarokUpdated issue summary.
Comment #25
podarok#1938634: Undefined index: iwq add folow-up for #22
Comment #25.0
podarokgmapextended tests
Comment #25.1
podarokUpdated issue summary.
Comment #25.2
podarokUpdated issue summary.
Comment #26
podarok#1938640: Undefined index: highlight_nodearg_color add follow-up for #22
Comment #26.0
podarokUpdated issue summary.
Comment #27
podarok#1938642: implode(): Invalid arguments passed add follow-up for #22
Comment #28
podarokbetter title and this is now common task
Comment #29
johnv@podarok,
although I see your test-submodules in the gmap directory, they do not appear in my 'modules' page, so I can't use them. Any tips? I'm on PHP5.2.
Comment #30
podarok#29 test submodules hidden from modules page
They needed only for "Testing" module during testing process
All You need for runing tests
Comment #31
johnvComment #32
podarokhere is a screenshot
Comment #33
podarok@johnv
here is a complete example for test only and patch with related fix #1938492: Undefined index: geofield
Comment #34
johnvYes, thanks, but problem is I do not see the tests at all..
Are there any modules that must be enabled before seeing them? (Testing, =OK, features =OK, ...)
Comment #35
podarokgmap, Testing
thats all
At screenshot You can see url for the page grabbed from
its for Drupal 7!
For Drupal 6 - there are few issues described in README.txt from git http://drupalcode.org/project/simpletest.git/blob/1633bd8c2cdaad5e5cc443...
Comment #36
podarokhttp://drupal.org/node/519364
Comment #37
johnvMy bad. I downloaded the 7.x Simpletest module, instead of using the core Simpletest.
Comment #38
podarok)))))
nobody perfect ))))))))))))))))))
Comment #38.0
podarokfixes