Certain attributes are missing from the HTML tag, for example, the dir attribute. There are contrib modules out there that rely on the dir attribute value in its javascript actions, which break functionality if the tag is not there to provide a value (and if said modules do not default).

CommentFileSizeAuthor
#1 bootstrap-add-dir-and-other-1935260-1.patch1.45 KBmarkhalliwell
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell commented
Status: Active » Needs review
FileSize
bootstrap-add-dir-and-other-1935260-1.patch1.45 KB

Fixed the missing attributes in html tag. Moved the shiv script before other scripts so it gets loaded first. Added profile to head tag. Added invisible skip to main content back in for accessibility.

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell commented

Is this an acceptable solution for you? (and others, chime in)

kevinquillen’s picture

kevinquillen CreditAttribution: kevinquillen commented

Yes - that would correct the issue.

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell commented
Status: Needs review » Fixed

Fixed in commit ac07b85.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.