Teaser splitter: more than one  corrupts node content [#193577]

When you have more than one < !--break-- > inputed into a node, you can save the node with the content, but when you edit the node, the data after the second < !--break--> is lost.

Steps to reproduce

Fresh Drupal install
Create a new node (page or story)

Input the following for the content:

This is the teaser! < !--break-->
This appears in the full story! < !--break-->
This appears after the full story! < !--break-->
This is the afterlife of the node....

Of course, you'll remove the space between the < and the ! in that example.

Save the node and you'll see that all content appears as expected
Now edit the node and instead of being able to edit all content, you're only able to edit up to the second < !--break-->.

Expected outcome is being able to edit all content in the node.

Comment	File	Size	Author
#14	teaser-break-weirdness-D6.patch	979 bytes	andypost
#14
#4	193577-teaser-break-weirdness.patch	972 bytes	Damien Tournoud
#4

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

LAsan CreditAttribution: LAsan commented 24 March 2008 at 16:19

Version:

6.x-dev

» 7.x-dev

Confirmed in 6.x-dev.
Still happening in 7.x-dev.

Comment #2

JeremyFrench CreditAttribution: JeremyFrench commented 17 April 2009 at 12:38

Should we strip instances of < !--break --> after the first, or honour them somehow?

Comment #3

Damien Tournoud CreditAttribution: Damien Tournoud commented 17 April 2009 at 13:05

Title:	More than one <!--break--> corrupts node content.	» Teaser splitter: more than one <!--break--> corrupts node content
Priority:	Minor	» Normal
Issue tags:		+JavaScript, +Novice

Confirmed.

This should be a simple bug into the teaser splitter javascript.

Comment #4

Damien Tournoud CreditAttribution: Damien Tournoud commented 27 April 2009 at 13:45

Status:

Active

» Needs review

File	Size
193577-teaser-break-weirdness.patch	972 bytes

The source of the bug is that the following javascript code:

string.split(<delimiter>, <limit>);

... doesn't behave as you would expect (at least it behaves differently then the PHP explode() function) [1]. Javascript will return only the first two components, ignoring the remaining of the string, so:

'a,b,c'.split(',', 2)

will return { 'a', 'b' } instead of { 'a', 'b,c' }

The attached patch fixes the issue (tested on Firefox 3).

[1] http://www.w3schools.com/jsref/jsref_split.asp

Comment #5

netsensei CreditAttribution: netsensei commented 28 April 2009 at 08:15

I've noticed the same issue in drupal 7.

Tested the patch. It works on these browsers:

- Safari 3.2.1 (osx)
- Camino 1.6.7 (osx)
- Firefox 3.0.9 and 3.0.10 (osx)

Comment #6

akahn CreditAttribution: akahn commented 29 April 2009 at 14:40

#1 indicates a use case where  is used more than twice. Shouldn't this patch allow more than two breaks (not that I have ever needed to do this on a site)?

Comment #7

Damien Tournoud CreditAttribution: Damien Tournoud commented 29 April 2009 at 14:54

@akahn: it does, the text between the beginning of the content and the first  is going in the teaser, the part after that (including subsequents ) is going to the body.