Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Now that modules and themes live in the site root, drush should put them there when downloading :)
Comment | File | Size | Author |
---|---|---|---|
#7 | drush-1936866.patch | 11.93 KB | jonhattan |
#5 | drush-1936866.patch | 6.3 KB | jonhattan |
#3 | drush-d8-dl-destination.patch | 879 bytes | greg.1.anderson |
Comments
Comment #1
jenlamptonyes, I said drush... not devel... more coffee please?
Comment #2
moshe weitzman CreditAttribution: moshe weitzman commentedAssigning to jonhattan, but it would be great if others could help.
Comment #3
greg.1.anderson CreditAttribution: greg.1.anderson commentedThis should about do it, but where does themes/engines go in D8? If it's at $root/themes/engines, then this should be good.
Comment #4
micahw156Patch applied cleanly, and download test worked for me. (In my case, into $root/modules/contrib)
Comment #5
jonhattanWe need more than #3. Atacched is my ongoing patch.
Notes:
* In D8 profile locations are symmetric to modules & themes.
* My patch prefers /contrib/ for profiles and themes in addition to modules.
Comment #6
moshe weitzman CreditAttribution: moshe weitzman commentedAny chance we can get a committable patch here?
Comment #7
jonhattanThis is quite more than it seemed initially.
Components/commands affected so far:
0. tests
1. search path for commands
2. pm-download
3. make
4. generate
5. archive-dump
Patch attached addresses 0-3. I'm having 14 failures in tests (D7). Not sure all of them are related.
Comment #8
jonhattanThe 14 failures I'm facing seems related to php 5.4 --or my 5.4 dev machine.
With php 5.3 only makeMakefileCase::testMakeRecursion is failing for me, but it is not related to this patch.
Comment #9
moshe weitzman CreditAttribution: moshe weitzman commentedAll testsare passing for me, with and without this patch.
The code here looks good. jonhattan is welcome to commit this when he is satisfied.
Comment #10
jwilson3I'm getting the following when applying the patch to 8.x-6.x branch codebase:
on a fresh install of drupal 8, using `drush si`, I have one non-core module, not enabled:
/modules/contrib/devel
before applying patch, `drush pml | grep devel` is empty.
after applying patch, `drush pml | grep devel` is still empty.
Is
pm-list
represented in one of the items in #7?This also makes it impossible to run `drush en devel` or `drush en devel_generate`.
Comment #11
jwilson3Hrm, can't see devel module from D8's admin UI module page either. Ignore me, until i can figure out whats going on. :-/
Comment #12
greg.1.anderson CreditAttribution: greg.1.anderson commentedResetting status; this should be committed.
@jwilson3: This issue is about where pm-download & c. puts modules at download time; if you have continuing issues related to enabling and disabling modules, please start a new thread.
Comment #13
jwilson3Ok, but `dl` doesn't work for me (trying to test this).
Note that it downloads to ~/Projects/Drupal/8.x/devel instead of ~/Projects/Drupal/8.x/modules/devel
What am I doing wrong?
Comment #14
jwilson3Update: not sure what happened, but it works better now... re-checked out origin/8.x-6.x (weird). I also fixed folder perms on sites/default/.
# drush dl devel
Project devel (8.x-1.x-dev) downloaded to /Users/jameswilson/Projects/Drupal/8.x/sites/default/modules/devel. [success]
Project devel contains 3 modules: devel_node_access, devel_generate, devel.
But i thought it's still supposed to download to /modules instead of sites/default/modules/ ?
Comment #15
jonhattanCommitted.
re #14: Before this patch, if sites/all doesn't exist, drush enforces sites/default/modules
Comment #16
moshe weitzman CreditAttribution: moshe weitzman commentedPretty sure this broke the tests. Assigning to jonhattan.
For example, if you run you get
phpunit pmDownloadTest.php
Comment #17
moshe weitzman CreditAttribution: moshe weitzman commentedFixed in db6322a