Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
For each mail sent, there is at least one log entry created, even when sent successfully. This might fill up you watchdog history quite quickly and have other messages purged. Sometimes you just don't want to keep an SMTP log (for example when sending a lot of mails).
This patch adds an option to disable watchdog logging.
Comment | File | Size | Author |
---|---|---|---|
#18 | smtp-option-to-disable-logging-1937416-18.patch | 8.42 KB | wundo |
Comments
Comment #1
wundo CreditAttribution: wundo commentederror: smtp.mail.inc: patch does not apply
Could you please re-roll?
Comment #2
interX CreditAttribution: interX commentedHere's a reroll against the latest dev (and slightly modified)
Comment #3
interX CreditAttribution: interX commentedComment #4
esolitosIs there any plan to get this committed? I found this veeery useful!
Comment #5
webservant316 CreditAttribution: webservant316 commentedyes I concur. I have the patch installed and depend upon it.
Comment #6
frankcarey CreditAttribution: frankcarey commentedReviewed it and it looks right to me. Note the patch only works with the 7.x-1.x-dev version (not 1.0)
Comment #9
wundo CreditAttribution: wundo commentedHere are a couple of changes I wanted to see before committing this:
Comment #10
mkolar CreditAttribution: mkolar commentedHere is re-roll against 7.x-1.x branch.
Patch slightly changed, I used old smtp_debugging variable and added update hook where I'm changing logging only errors if old variable was 1. Hope it's as you wanted.
By the way patch https://www.drupal.org/node/1292490 should be changed regarding this new behavior (Im going to do it).
Comment #11
mkolar CreditAttribution: mkolar commentedI'm sorry I accidentally used wrong node id and title in patch name because was working with more patches in one time :( I can't change it.
Comment #12
mkolar CreditAttribution: mkolar commentedComment #13
Fabianx CreditAttribution: Fabianx commentedComment #14
mkolar CreditAttribution: mkolar commentedI used wrong variable from old patch in some places. Here is the fix. File name is correct now I hope :).
Comment #15
mkolar CreditAttribution: mkolar commentedComment #16
Fabianx CreditAttribution: Fabianx commentedComment #17
mkolar CreditAttribution: mkolar commentedComment #18
wundo CreditAttribution: wundo commentedSorry to change from RTBC to needs review, but I've basically re-wrote the whole patch fixing some confusion about the default logging level, doxygen errors, and standardizing using the logging level constants across the whole module.
Comment #19
Fabianx CreditAttribution: Fabianx commentedLooks still good to me.
Comment #20
wundo CreditAttribution: wundo commented