Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Pol’s picture

Status: Active » Needs review
FileSize
840 bytes
Pol’s picture

Forgot to update the comment.

Status: Needs review » Needs work

The last submitted patch, 0001-Fix-1937446-Add-a-new-hook-pre-dependencies-load.patch, failed testing.

Pol’s picture

Fix on the patch + tests

Pol’s picture

Status: Needs work » Needs review
tstoeckler’s picture

Let's see what the test-bot says this time. This looks good to go!

In a follow-up we should add dedicated tests for the new callback group. Because the previous patches demonstrate that we have sufficient test coverage, and, thus, that this patch doesn't break anything, and because @Pol needs this for OpenLayers, I will commit the patch as is, instead of requiring the tests now. If now one beats me to it, I will provide some tests. (Should be mostly copy-paste.)

Status: Needs review » Needs work

The last submitted patch, Fix-1937446-Add-a-new-hook-pre-dependencies-load.patch, failed testing.

Pol’s picture

Status: Needs work » Needs review
FileSize
7.88 KB

Tests still failling, I can't fix it.

Status: Needs review » Needs work

The last submitted patch, Fix-1937446-Add-a-new-hook-pre-dependencies-load.patch, failed testing.

tstoeckler’s picture

Status: Needs work » Needs review
FileSize
2.26 KB
7.74 KB

Here we go. This includes test-coverage, which was (even) easier than I expected.

Pol’s picture

Status: Needs review » Reviewed & tested by the community

\o/

tstoeckler’s picture

Thanks! I'll commit this later.

In case @sun is following along at home, I plan to release a new version with this commit, because @Pol needs it for OpenLayers.

tstoeckler’s picture

Status: Reviewed & tested by the community » Fixed

Pre commit I fixed the trailing whitespace and also added an example pre-dependencies-load callback to the example library.

Committed this to 7.x-2.x
http://drupalcode.org/project/libraries.git/commit/7d2a3db42f7553dca65e6...

hass’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

tstoeckler’s picture