Convert file theme tables to table #type

Anyone up for this in portland.

I'll give it a shot. Here's hoping I can wrap my brain around it!

I regret to say I need to punt on this for now due to a prior engagement...you're right, duellj, this is damned tricky. I'll try to get back to this if I can, but if anyone else wants to take this on, please feel free!

The function really needs to be refactored, but that's for another issue. Here is a straightforward patch.

Aaaannddd... whitespace errors *facepalm*

Here's an updated patch.

#7: file-widget-multiple-table-1938902-7.patch queued for re-testing.

Re-roll

Removing theme_file_formatter_table() since not a form element

I added instructions to do manual testing and did some!

It looks fine when there are some items in the table. However, it doesn't match the previous behavior when there are no items! See the screenshots below.

Before the patch

When empty:

With two files uploaded:

After the patch

When empty:

With two files uploaded:

Attached is a new version of the patch which some of the changes reverted, which fixes the bug I pointed out in #11. Please let me know what you think!

Actually, I started thinking about this and I think this patch is going in the wrong direction. It's replacing the code in theme_file_widget_multiple(), but what it probably should be doing is REMOVING that theme function all together and put the '#type' => 'table' element directly into the form!

Oops! Well, here is the real patch that should have been for #12. :-) However, the next one I make will take the different approach I described in #13.

#15: file-widget-multiple-table-1938902-15.patch queued for re-testing.

#15: file-widget-multiple-table-1938902-15.patch queued for re-testing.

This is likely not going to pass all tests but this is closer to what the conversion should look like.

If you just run the existing code through #rows attribute none of #type=> tables magic happens. Which includes doing the row sorting for you.

Also #empty still shows the header and the way it's used doesn't achieve the style you are looking for without the headers.

Hope that helps, and for the failures and exceptions maybe you can look into why those may be.

I've tested this manually but the tests either need to change or maybe #parents need to be put on some of the elements. @see https://drupal.org/node/1876710 for reference to what I did here. Also, if you don't understand let me know and I'll comment lines for clarity.

FYI, type=>table is not my favourite thing to build... it's a lot of work for little gain. Hopefully the removed loops will help a bit with performance testing.

#19: 1938902-19-type-table-file.patch queued for re-testing.

19: 1938902-19-type-table-file.patch queued for re-testing.

Updating issue tag. Will have a look at Drupal Camp Mumbai sprint on this weekend

Seems like we already use '#type' => 'table', so what we need to do ?
file.field.inc:131

  $variables['table'] = array(
    '#type' => 'table',
    '#header' => $headers,
    '#rows' => $rows,
    '#attributes' => array(
      'id' => $table_id,
    ),
    '#tabledrag' => array(
      array(
        'action' => 'order',
        'relationship' => 'sibling',
        'group' => $weight_class,
      ),
    ),
  );

Closing as dupe of #1898070: file.module - Convert theme_ functions to Twig, since that's where this task was completed.