Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Task
Convert the following theme functions to use the new table #type:
| Module | Theme function name | Where in Code | What is it really? |
|---|---|---|---|
| shortcut | theme_shortcut_set_customize | function | form table draggable |
Related issues
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | table-type-shortcuts-1938924-4.patch | 4.64 KB | joelpittet |
| #2 | table-type-shortcuts-1938924-2.patch | 0 bytes | joelpittet |
Comments
Comment #1
duellj CreditAttribution: duellj commentedWaiting to hear feedback from #1898450: shortcut.module - Convert theme_ functions to Twig
Comment #2
joelpittetThis should do the trick and I am pretty sure one less theme_ function is the plan for these {{ form }}{{ table }} looking twig files
Comment #3
joelpittettestbot ACTIVATE!
Comment #4
tlattimore CreditAttribution: tlattimore commentedThe patch #2 is empty. Joelpittet may be already working on re-rolling this but for now I going to mark back to needs work.
Comment #5
joelpittetJust testing you test bot, and you PASSED kinda... ok engage or something.
Comment #6
joelpittetCould someone confirm this is as it should be and/or RTBC?
Comment #7
joelpittet#5: table-type-shortcuts-1938924-4.patch queued for re-testing.
Comment #8
jibranTagging.
Comment #9
jibran#5: table-type-shortcuts-1938924-4.patch queued for re-testing.
Comment #11
joelpittettagging
Comment #12
sidharthapPatch no longer applies as the current feature is class base structures. Now module is using buildHeader() and buildRow() to create the list. correct me if i am wrong!
Comment #13
joelpittetYou are correct, this has been done in another issue. #1978956: Convert shortcut_set_customize to a Controller