I just done a bulk update, applied a number of patches to WYSIWYG and noticed during testing that the insert media styles that had a crop attached no longer worked.

I have set image_allow_insecure_derivatives to TRUE

Appears to be a bug, but I don't have a clean environment to test atm

Comments

David_Rothstein’s picture

heatherwoz’s picture

Status: Active » Fixed

After some investigation, I realized that the fix for #1845750: insert button not working properly in combination with insert module. resolves this issue. Previous version of Manual Crop didn't implement hook_insert_content() - upgraded to latest dev and insert works correctly now.

Alan D.’s picture

I can confirm this too :)

Fails using Insert 7.x-1.3 + Manual Crop 7.x-1.4

Works after upgrading to Manual Crop 7.x-1.4+26-dev

David_Rothstein’s picture

Cool. I went ahead and removed this module from the list at http://drupal.org/drupal-7.20-release-notes, since this problem doesn't seem to have anything to do with the Drupal 7.20 update after all. (The problem above happens on Drupal 7.19 too and the same fix solves it.)

heatherwoz’s picture

Actually you might consider putting it back. Most users will be on the official release of Manual Crop, not dev, and when they run into the problem they may mistakenly assume it is caused by the Drupal upgrade, as we did. Linking to this issue will help them find the solution quickly.

David_Rothstein’s picture

Was this problem actually introduced as a result of Insert 7.x-1.3? I had the impression it was introduced in an older version.

If it's an older problem (that some people are hitting now only because they hadn't done previous updates of the Insert module), then I don't want to introduce confusion by adding it to the Drupal 7.20 release notes. But if it's specific to 7.x-1.3 then I will.

I'm also already linking off to both the Insert module project page and release notes from the Drupal 7.20 notes, so you could consider filing an issue with Insert module to have something about it mentioned on those pages. If Insert module made some changes at some point that caused incompatibilities with other modules such as Manual Crop, then I would think that's the most effective place to mention the situation.

Matthijs’s picture

The current stable version of Manual Crop is not compatible with Drupal 7.20 and up (see #1949510: Http cache control query string broken with update to Drupal 7.20). I've updated the project homepage until a new stable release is being released, but I want to close some more issues before I do that ;-)

Matthijs

David_Rothstein’s picture

Oh, OK. Thanks for letting me know; I've gone ahead and added Manual Crop back to the Drupal 7.20 release notes (and linked to that issue rather than this one).

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.