Add Leaflet to Packaging Whitelist

Looks like it's 'a BSD license', according to the Apache foundation: https://issues.apache.org/jira/browse/LEGAL-132

However, I'd like to hear from someone more well-versed in the intricacies of GPL license compatibility before RTBCing this project. It'd be much easier if Leaflet could clarify somewhere exactly what kind of license they're using. It doesn't like like an exact copy of a standard BSD license I've seen.

sub

Per #2, I've reformatted the Leaflet licence on Github to wrap to 80 characters so that it can be properly compared to the BSD 2-clause license (from Wikipedia).

I'm attaching both here with a diff of the changes between the two.

To me, it is clear, for all intents and purposes, that Leaflet license *IS* the BSD 2-clause license, minus the specific blurb about FreeBSD.

Per http://www.gnu.org/licenses/license-list.html#FreeBSD, the FreeBSD 2-clause license is compatible with GPL.

Added: https://drupal.org/node/2019807

A request was made in alter this whitelist entry.

#2047155: Fix leaflet library URL filter

I've added the regex so it's possible to download from leaflet-cdn.s3.amazonaws.com in a .make, but now @Mac_Weber is suggesting we should remove the github URLs.

What @Mac_Weber is saying about the GitHub URLs being useless in Drupal .make seems correct, but I don't use this library so I'd like to get some feedback from the people involved in the original request before I remove something someone may actually be using.

@acouch, @GJdan, or @jwilson3 can you confirm?

I can confirm that adding the non-github alternate cdn is the right thing to do.

It's ashame the leaflet github repo doesn't host its own compiled version on a separate branch or something.

But also, there is no harm in leaving the github repo regex there.

Thanks for the quick reply. I'm removed the github regexes since they aren't usable at this time. It's easy enough to re-add them if Leaflet changes their packaging.

I think removing github is premature... The drupal Leaflet module documentation page states:

Leaflet will look for the necessary Javascript files in the folder sites/all/libraries/leaflet/dist.

So If you're building a profile that depends on the leaflet drupal module, which depends on the leaflet library, it seems it still *prefers* the layout from the github.

I havent actually checked the module yet, or the issue queue to see if they've updated the code and the docs are lacking or what.

That documentation page points to http://leafletjs.com/ for the download and downloading from github doesn't get you the necessary leaflet.js file in /dist. This is all you get from github...

dist
leaflet.css
leaflet.ie.css
-images
--layers-2x.png
--layers.png
--marker-icon-2x.png
--marker-icon.png
--marker-shadow.png

I think this is why the request was made in the first place. From what I can tell, there's no way to download a working version of leaflet.js from that github repo which is why everything points to http://leafletjs.com/downloads.

If I'm wrong, I'm happy to change this.

I think removing github is premature... The drupal Leaflet module documentation page states:

Leaflet will look for the necessary Javascript files in the folder sites/all/libraries/leaflet/dist.

I reaffirm the github shall be removed. The leaflet module has a bug because in the past it had the full compiled library in github. The github repo is not supposed to be a repo for the the library itself, it is a builder for the library. Now, the library developers understand that if someone is going to download a builder they are supposed to be doing it to compile using only the parts they need in the library, not the full library as available from download page in their website.

There is an open issue in which the leaflet module maintainers have to merge in order to fix it. The instructions there are also wrong and my patch there also corrects it. #1954942: Leaflet library not found

You can confirm it in the Leaflet library's download page:

Leaflet Source Code

These download packages above only contain the library itself. If you want to download the full source code, including unit tests, files for debugging, build scripts, etc., you can download it from the GitHub repository.

It is clear the source code is only the builder for the library and will not work in Drupal.

Great. Thanks for taking the time to delve into the solution!